Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade viper #1312

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: downgrade viper #1312

merged 1 commit into from
Apr 18, 2024

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Apr 17, 2024

Description

I think the aws dep bumped viper in the last tracing PR, and 1.18 has this issue spf13/viper#1706.

we can do this or celestiaorg/cosmos-sdk#389

main uses v1.13 of viper, but 1.15 is the lowest we can use without a replace statement on this branch

@evan-forbes evan-forbes requested a review from a team as a code owner April 17, 2024 22:49
@evan-forbes evan-forbes requested review from rootulp, cmwaters, staheri14 and rach-id and removed request for a team April 17, 2024 22:49
@evan-forbes evan-forbes self-assigned this Apr 17, 2024
@evan-forbes evan-forbes added the T:Bug Type: Bug (confirmed) label Apr 17, 2024
@evan-forbes evan-forbes enabled auto-merge (squash) April 17, 2024 23:31
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@evan-forbes evan-forbes merged commit ca8bd53 into v0.34.x-celestia Apr 18, 2024
20 of 21 checks passed
@evan-forbes evan-forbes deleted the evan/downgrade-viper branch April 18, 2024 12:59
@@ -42,7 +42,7 @@ require (
github.com/sasha-s/go-deadlock v0.3.1
github.com/snikch/goodman v0.0.0-20171125024755-10e37e294daa
github.com/spf13/cobra v1.8.0
github.com/spf13/viper v1.18.1
github.com/spf13/viper v1.15.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I'm late but this may get reverted by dependabot so we could add a replace statement to stay pinned to this version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Bug Type: Bug (confirmed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants