feat!: wrap ShareProof in ResultShareProof

[rach-id]

Description

This PR wraps the ShareProof into a ResultShareProof in the API. However, It doesn't change the custom query response since it's internal data and there is no need to wrap it.

Closes #1306

[rootulp]

Just flagging that AFAIK celestia-app has no immediate plans to upgrade to a release cut from the celestia-core main branch because main contains breaking changes to ABCI methods. In other words, I don't think this should target main. IMO we should make the fix in a non-breaking way and target v0.34.x-celestia branch, then cut a minor release of celestia-core, and bump to it in celestia-app main and v1.x. That way we can fix this way before celestia-app v2 is released.

[rach-id]

We can wait until v2 is released for this fix, no one is asking for this urgently, that's why I am targetting main and going for the easy fix

[cmwaters]

LGTM. If there's no urgency and it's just a code hygiene change then we can leave it in main else we can also backport this to v0.34.x-celestia in a non-breaking way (as Rootul suggests)

As a side question, is this endpoint just for blobstream or are there other users of it. I assume celestia-node doesn't meed it

[rach-id]

I assume celestia-node doesn't meed it

Yes, they don't. In fact, there is a work towards having similar proofs in node but it's not highly prioritized

[rootulp]

Just flagging this won't get included in celestia-app anytime soon because we're not planning on cutting a release from the main branch of this repo. @rach-id If you want this used by celestia-app, you need to backport this to v0.34.x-celestia and then cut a new release and bump to it in celestia-app

[rach-id]

We're planning on having it in v2, so it can wait. Thanks

[rootulp]

celestia-core main won't be used for celestia-app v2. If you do nothing this PR won't be used in celestia-app v2.

[rach-id]

Oh really? Won't v2 be cut from main when we want to bump app to v2?
Which branch would it be?

[rootulp]

Likely v0.34.x-celestia. There's a lot of confusion about release branches currently and we're still working on a strategy but I'm pretty confident main won't be used for the forseeable future. It may be used for celestia-app v3. A more applicable name for main may be experimental-unfork at least for now.

Ref:

• Rename v0.34.x-celestia branch to v1.x #1305
• https://docs.google.com/document/d/1mTrM6BB95uTkfM60BPHDM2a1_jCmSB_lqg_2K1hhO1A

[rach-id]

Thanks for linking this 🙏 Once there is a decision around which branch will be used to cut v2, let's backport this PR there

[rootulp]

FYI we had another meeting about celestia-core release branches without a firm decision on which branch celestia-app will use for v2. See notes.

[rach-id]

Thanks for keeping me in the loop 🙏 Let's hope to have a decision soon :D