chore: improve request prepare proposal comments #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
cmwaters and
staheri14
and removed request for
a team
cmwaters
approved these changes
Jun 14, 2024
staheri14
approved these changes
Jun 14, 2024
| // block_data is an array of transactions that will be included in a block, | ||
| // sent to the app for possible modifications. | ||
| // applications can not exceed the size of the data passed to it. | ||
| // BlockData is a slice of candidate transactions that may be included in a |
There was a problem hiding this comment.
[nit]
Suggested change
| // BlockData is a slice of candidate transactions that may be included in a | |
| // block_data is a slice of candidate transactions that may be included in a |
There was a problem hiding this comment.
I would rather use BlockData because IMO more people are likely to read the generated Go comments instead of the raw protobuf comments.
| tendermint.types.Data block_data = 1; | ||
| // If an application decides to populate block_data with extra information, they can not exceed this value. | ||
| // BlockDataSize is the maximum size (in bytes) that BlockData should be. |
There was a problem hiding this comment.
[nit]
Suggested change
| // BlockDataSize is the maximum size (in bytes) that BlockData should be. | |
| // block_data_size is the maximum size (in bytes) that BlockData should be. |
ninabarbakadze
approved these changes
Jun 17, 2024
rootulp
added
the
S:backport-to-main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1390