Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates go version to 1.22.6 #1463

Merged
merged 1 commit into from
Aug 26, 2024
Merged

chore: updates go version to 1.22.6 #1463

merged 1 commit into from
Aug 26, 2024

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Aug 26, 2024 •
edited
Loading

To align with the go version used in celestia-app main branch.

@staheri14 staheri14 self-assigned this Aug 26, 2024
@staheri14 staheri14 marked this pull request as ready for review August 26, 2024 20:17
@staheri14 staheri14 requested a review from a team as a code owner August 26, 2024 20:17
@staheri14 staheri14 requested review from rach-id, ninabarbakadze, evan-forbes and rootulp and removed request for a team August 26, 2024 20:17
rootulp
rootulp approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

  1. We may bump to Go 1.23 soon b/c celestia-node already did it
  2. We can minimize the diff for future PRs by updating workflow files to use go.mod like this

@evan-forbes evan-forbes merged commit 4f651fa into v0.34.x-celestia Aug 26, 2024
21 checks passed
@evan-forbes evan-forbes deleted the sanaz/bumps-to-go1.22.6 branch August 26, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@rootulp rootulp rootulp approved these changes

@rach-id rach-id Awaiting requested review from rach-id rach-id is a code owner automatically assigned from celestiaorg/celestia-core

@ninabarbakadze ninabarbakadze Awaiting requested review from ninabarbakadze ninabarbakadze is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@staheri14 staheri14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staheri14 @rootulp @evan-forbes