Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retrieves timeout propose and timeout commit dynamically per height according to the app version #1494

Merged
merged 91 commits into from
Oct 15, 2024
Merged

feat: retrieves timeout propose and timeout commit dynamically per height according to the app version #1494

merged 91 commits into from
Oct 15, 2024

Commits on Sep 18, 2024

  1. extends ResponseEndBlock protobuf message with timeouts

    @staheri14
    staheri14 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f231895 View commit details
    Browse the repository at this point in the history

  2. reads the timeouts and attempts to set them

    @staheri14
    staheri14 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    41a2cb0 View commit details
    Browse the repository at this point in the history

  3. extends state struct with timeout fields

    @staheri14
    staheri14 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1fc1edf View commit details
    Browse the repository at this point in the history

  4. updates timeouts based on EndBlockResponse

    @staheri14
    staheri14 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    597f667 View commit details
    Browse the repository at this point in the history

  5. updates consensus configs based on ApplyBlock's results

    @staheri14
    staheri14 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2397315 View commit details
    Browse the repository at this point in the history

  6. changes the type of timeout fields in protobuf to uint64

    @staheri14
    staheri14 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    03fb213 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. uses time.Duration for protobuf fields

    @staheri14
    staheri14 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a104580 View commit details
    Browse the repository at this point in the history

  2. adds timeout fields to RequestInfo

    @staheri14
    staheri14 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    30bc1c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. consolidates timeouts inside one protobuf message type

    @staheri14
    staheri14 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7b3618b View commit details
    Browse the repository at this point in the history

  2. moves tiemouts to the response msg

    @staheri14
    staheri14 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fa27abe View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. adds timemouts to InitchainRespo se

    @staheri14
    staheri14 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6e2fb78 View commit details
    Browse the repository at this point in the history

  2. corrects some of the docs

    @staheri14
    staheri14 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a7d1e1b View commit details
    Browse the repository at this point in the history

  3. remnants of adding timeouts to the InitchainResponse

    @staheri14
    staheri14 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0904cd5 View commit details
    Browse the repository at this point in the history

  4. disambiguates a comment

    @staheri14
    staheri14 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0271370 View commit details
    Browse the repository at this point in the history

  5. minor edits

    @staheri14
    staheri14 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    47329db View commit details
    Browse the repository at this point in the history

  6. adds some todos

    @staheri14
    staheri14 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8ef6666 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. fixes godocs

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6a92b18 View commit details
    Browse the repository at this point in the history

  2. adds timeouts to the State protobuf message to be saved in the statedb

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    782efa1 View commit details
    Browse the repository at this point in the history

  3. fixes godocs

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    26dfedf View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/v0.34.x-celestia' into sanaz/add… 

    …s-timeouts-to-endblock-abci
    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    020efac View commit details
    Browse the repository at this point in the history

  5. makes timeouts field not nullable

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    490189c View commit details
    Browse the repository at this point in the history

  6. exposes Timeout fields of the State

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    852d07f View commit details
    Browse the repository at this point in the history

  7. copies over timeout values when converting from proto to local state … 

    …and vice versa
    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f1568a6 View commit details
    Browse the repository at this point in the history

  8. tests copying timeouts

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    00d8e1c View commit details
    Browse the repository at this point in the history

  9. extends TestStateSaveLoad to account for timeout equality

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3b6cbb3 View commit details
    Browse the repository at this point in the history

  10. adds a clarifying comment

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    98feed8 View commit details
    Browse the repository at this point in the history

  11. integrates timeouts in TestABCIResponsesSaveLoad1

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9ecf2d1 View commit details
    Browse the repository at this point in the history

  12. sets non-zero timeouts for the TestStateProto

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    063fafd View commit details
    Browse the repository at this point in the history

  13. creates a new testcase for state with non-zero tiemouts

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bbfbd59 View commit details
    Browse the repository at this point in the history

  14. sets the initial state's timeouts using InitChainResponse timeouts

    @staheri14
    staheri14 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    77e31ca View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. improves docs

    @staheri14
    staheri14 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b8b7b5a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. adds a todo about setting timeouts in stateSync

    @staheri14
    staheri14 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d48a120 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. saves timeouts separately in the store

    @staheri14
    staheri14 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6d53ec3 View commit details
    Browse the repository at this point in the history

  2. fixes a godoc

    @staheri14
    staheri14 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4d79406 View commit details
    Browse the repository at this point in the history

  3. adds a todo

    @staheri14
    staheri14 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    eddd24b View commit details
    Browse the repository at this point in the history

  4. logs timeout propose and timeout commit

    @staheri14
    staheri14 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    647cd29 View commit details
    Browse the repository at this point in the history

  5. logs timeouts in second unit

    @staheri14
    staheri14 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ca5cbf6 View commit details
    Browse the repository at this point in the history

  6. checks if config is not nil

    @staheri14
    staheri14 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    bf59cd5 View commit details
    Browse the repository at this point in the history

  7. removes the logs

    @staheri14
    staheri14 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    585d682 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. extends store interface with LoadConsensusTimeoutsInfo

    @staheri14
    staheri14 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bd49c4c View commit details
    Browse the repository at this point in the history

  2. adds two new methods for calculation of timeouts

    @staheri14
    staheri14 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2c24116 View commit details
    Browse the repository at this point in the history

  3. utilizes new methods for commit time and timeout propose

    @staheri14
    staheri14 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    61ea40b View commit details
    Browse the repository at this point in the history

  4. adds logs

    @staheri14
    staheri14 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5dca0dc View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/v0.34.x-celestia' into sanaz/add… 

    …s-timeouts-to-endblock-abci
    @staheri14
    staheri14 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bebd8d5 View commit details
    Browse the repository at this point in the history

  6. updates protobufs

    @staheri14
    staheri14 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4831733 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. adds further logs for monitoring timeout changes during consensus ope… 

    …rations
    @staheri14
    staheri14 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cfdd2c3 View commit details
    Browse the repository at this point in the history

  2. logs timeouts when calculated

    @staheri14
    staheri14 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e3ae19c View commit details
    Browse the repository at this point in the history

  3. removes some of logs

    @staheri14
    staheri14 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1e08820 View commit details
    Browse the repository at this point in the history

  4. removes some logs

    @staheri14
    staheri14 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f8eaf2d View commit details
    Browse the repository at this point in the history

  5. minor fix and godoc update

    @staheri14
    staheri14 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    eff0bb2 View commit details
    Browse the repository at this point in the history

  6. logs the state and the header's app version after each ApplyBlock

    @staheri14
    staheri14 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9865ebe View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. adds an rpc route for timeout info

    @staheri14
    staheri14 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6f88a30 View commit details
    Browse the repository at this point in the history

  2. implements ConsensusTimeoutsInfo for baseRPCClient

    @staheri14
    staheri14 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3f8320f View commit details
    Browse the repository at this point in the history

  3. adds some missing parts

    @staheri14
    staheri14 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d6ecfd4 View commit details
    Browse the repository at this point in the history

  4. adds a test for the retrieval of timeout info per height

    @staheri14
    staheri14 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d8815a3 View commit details
    Browse the repository at this point in the history

  5. fixes a comment

    @staheri14
    staheri14 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    377751e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. revises the test to retrieve states after all are saved

    @staheri14
    staheri14 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    598e9be View commit details
    Browse the repository at this point in the history

  2. fixes a typo

    @staheri14
    staheri14 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a34d103 View commit details
    Browse the repository at this point in the history

  3. covers a tricky corner case for the genesis state

    @staheri14
    staheri14 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f06eae6 View commit details
    Browse the repository at this point in the history

  4. does not amend configs in updatoToState

    @staheri14
    staheri14 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3347fe7 View commit details
    Browse the repository at this point in the history

  5. formats some lines

    @staheri14
    staheri14 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fbe4f62 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. implements ConsensusTimeoutsInfo for the local client

    @staheri14
    staheri14 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    86bd130 View commit details
    Browse the repository at this point in the history

  2. converts height ptr to int64

    @staheri14
    staheri14 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8fe698f View commit details
    Browse the repository at this point in the history

  3. converts height ptr to int64

    @staheri14
    staheri14 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5785b37 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'sanaz/adds-timeouts-to-endblock-abci' of github.com:cel… 

    …estiaorg/celestia-core into sanaz/adds-timeouts-to-endblock-abci
    @staheri14
    staheri14 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f7cda78 View commit details
    Browse the repository at this point in the history

  5. implements ConsensusTimeoutsInfo for the mock client

    @staheri14
    staheri14 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    66f3f21 View commit details
    Browse the repository at this point in the history

  6. fixes redundant imports

    @staheri14
    staheri14 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0ebf51c View commit details
    Browse the repository at this point in the history

  7. implements a missing method for the mock store

    @staheri14
    staheri14 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ee9bda2 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. falls back to the configs timeouts if none is available in the state

    @staheri14
    staheri14 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9f11257 View commit details
    Browse the repository at this point in the history

  2. clarifies why a test case is valid under the new implementation

    @staheri14
    staheri14 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    aabf2c6 View commit details
    Browse the repository at this point in the history

  3. adds further clarifying comments about the tests that use the timeout… 

    … propose in the cofig
    @staheri14
    staheri14 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5e7abef View commit details
    Browse the repository at this point in the history

  4. comments on the new methods for Commit and Propose time calculation

    @staheri14
    staheri14 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    98e3e13 View commit details
    Browse the repository at this point in the history

  5. deletes fmt statements

    @staheri14
    staheri14 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fc2fc76 View commit details
    Browse the repository at this point in the history

  6. deletes a todo

    @staheri14
    staheri14 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    30a663f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. replaces Propose calls with ProposeWithCustomTimeout

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d7e21f4 View commit details
    Browse the repository at this point in the history

  2. uses last state timeout for the tests

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d872374 View commit details
    Browse the repository at this point in the history

  3. removes some unused comments

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1776442 View commit details
    Browse the repository at this point in the history

  4. implements ConsensusTimeoutsInfo for the light client

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6211697 View commit details
    Browse the repository at this point in the history

  5. fixes some formatting inconsistencies

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    122058b View commit details
    Browse the repository at this point in the history

  6. cleans up the code

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f74d19b View commit details
    Browse the repository at this point in the history

  7. clarifies a comment

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0fd7f5e View commit details
    Browse the repository at this point in the history

  8. sets the inital value of timeouts to the custom timeout

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    10be8b1 View commit details
    Browse the repository at this point in the history

  9. adds unttest for ProposeWithCustomTimeout and CommitWithCustomTimeout

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    363058a View commit details
    Browse the repository at this point in the history

  10. clarifies what default means

    @staheri14
    staheri14 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    85e92f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. chore: comment feedback @rootulp

    @evan-forbes
    evan-forbes committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5d399b5 View commit details
    Browse the repository at this point in the history

  2. chore: review feedback

    @evan-forbes
    evan-forbes committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    081ecce View commit details
    Browse the repository at this point in the history

  3. chore: remove rpc and timeouts from the state store

    @evan-forbes
    evan-forbes committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f12da04 View commit details
    Browse the repository at this point in the history

  4. fix: use the timeouts passed from info

    @evan-forbes
    evan-forbes committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    12639d4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'sanaz/adds-timeouts-to-endblock-abci' of github.com:cel… 

    …estiaorg/celestia-core into sanaz/adds-timeouts-to-endblock-abci
    @evan-forbes
    evan-forbes committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e772715 View commit details
    Browse the repository at this point in the history

  6. chore: linter

    @evan-forbes
    evan-forbes committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1ef98d0 View commit details
    Browse the repository at this point in the history

  7. chore: remaining two comments

    @evan-forbes
    evan-forbes committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    23e3fb1 View commit details
    Browse the repository at this point in the history