Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data availability for evidence #19

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Data availability for evidence #19

merged 2 commits into from
Apr 18, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Apr 18, 2020 •
edited
Loading

Followup PR for #16 / #17:

  • use HexBytes instead of []byte for hashes
  • move Evidence to Data to guarantee its availability

Note that preferably we would introduce a hash type (see #17 (comment)). Here we only consistently use the data type that is used in other places for this purpose.

After this PR gets merged, I'll start with adding in the RSMT2D for computing roots.

@liamsi liamsi requested a review from adlerjohn April 18, 2020 14:43
@liamsi liamsi marked this pull request as ready for review April 18, 2020 16:43
@liamsi liamsi merged commit ed55b0c into master Apr 18, 2020
@liamsi liamsi deleted the ismail/move_evidence branch April 18, 2020 20:41
@liamsi liamsi added this to the lazyledger-core 1.0.0-alpha milestone Apr 22, 2020
@liamsi liamsi mentioned this pull request Nov 3, 2022
Closed
@rootulp rootulp mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
lazyledger-core 1.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@liamsi @adlerjohn