Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset to tendermint master #534

Merged
merged 732 commits into from
Sep 28, 2021
Merged

Reset to tendermint master #534

merged 732 commits into from
Sep 28, 2021
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jul 6, 2021

  1. Configuration menu
    Copy the full SHA
    1dec3e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. state/indexer: close row after query (#6664)

    Closes: #6661 
    
    Note: see another error during the events indexing, guess the raw tx size exceeds the limitation?
    ```
    3:17PM ERR failed to index block txs err="pq: index row size 2768 exceeds btree version 4 maximum 2704 for index \"tx_results_tx_result_key\"" height=5205112 module=txindex
    JayT106 authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    e850863 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    800cce8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d4cda54 View commit details
    Browse the repository at this point in the history
  4. deps: remove pkg errors (#6666)

    ## Description
    
    remove pkg/errors since we use the provided fmt.Errorf
    tac0turtle authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    96863de View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3ccfb26 View commit details
    Browse the repository at this point in the history
  6. abci: Fix gitignore abci-cli (#6668)

    Closes #6663
    tanyabouman authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    ba3f710 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d882f31 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. internal/blockchain/v0: prevent all possible race for blockchainCh.Ou…

    …t (#6637)
    
    This commit extends the fix in #6518, so all other goroutine which run
    concurrently with processBlockchainCh can safely send data to blockchain
    out channel via a bridge channel. This helps eliminating all possible
    data race with sending and closing blockchainCh.Out channel at the same
    time.
    
    Fixes #6516
    Cuong Manh Le authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    37bc1d7 View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump gaurav-nelson/github-action-markdown-link-check (#6…

    …679)
    
    Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.12 to 1.0.13.
    - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
    - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.12...1.0.13)
    
    ---
    updated-dependencies:
    - dependency-name: gaurav-nelson/github-action-markdown-link-check
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    c7c11fc View commit details
    Browse the repository at this point in the history
  3. adjust tx load (#6681)

    cmwaters authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    9d93607 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c256edc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cd24857 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2c14d49 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. deps: run go mod tidy (#6677)

    ## Description
    
    Run go mod tidy
    tac0turtle authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    69848be View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump github.com/golangci/golangci-lint (#6686)

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.38.0 to 1.41.1.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.38.0...v1.41.1)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    7ca0f24 View commit details
    Browse the repository at this point in the history
  3. p2p: remove annoying error log (#6688)

    I put this error log in here because I thought it might be a helpful indicator to see when a reactor sends a message to a peer that doesn't have that channel open but it turns out this is happening all the time and it's kind of annoying
    cmwaters authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    decac69 View commit details
    Browse the repository at this point in the history
  4. tools: move tools.go to subdir (#6689)

    ## Description
    
    Move tools to subdir to fix `go get`
    tac0turtle authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    5530726 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    051e127 View commit details
    Browse the repository at this point in the history
  6. statesync: keep peer despite lightblock query fail (#6692)

    When a peer responds with no lightblock for the height we queried, we call the [removePeer method](https://github.com/tendermint/tendermint/blob/master/internal/statesync/reactor.go#L339). This removes the peer from the [dispatcher's list of called peer's](https://github.com/tendermint/tendermint/blob/ad6588315256162a9ef799a5a77ab7237cd46f38/internal/statesync/dispatcher.go#L159). When the dispatcher then receives responses from the removed peer, it [drops their responses](https://github.com/tendermint/tendermint/blob/ad6588315256162a9ef799a5a77ab7237cd46f38/internal/statesync/dispatcher.go#L130). These responses may be meaningful or contain a block or data that will help statesync proceed.
    
    [The logs](https://gist.github.com/tychoish/34a1f61eaae3c36c23efc7d0001e805c), when this change is applied, show an additional 3 networking testnets passing. 
    
    addresses:  #6691
    williambanfield authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    50b00df View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    581dd01 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Configuration menu
    Copy the full SHA
    aa4854f View commit details
    Browse the repository at this point in the history
  2. abci: remove counter app (#6684)

    * remove counter app
    
    * remove unneeeded ci
    
    * lint fix
    
    * modify tx sizes
    
    * cleanup docs
    
    * Update abci/cmd/abci-cli/abci-cli.go
    
    Co-authored-by: Callum Waters <cmwaters19@gmail.com>
    
    * Update docs/app-dev/getting-started.md
    
    Co-authored-by: Callum Waters <cmwaters19@gmail.com>
    
    * Update docs/app-dev/getting-started.md
    
    Co-authored-by: Callum Waters <cmwaters19@gmail.com>
    
    * bring back comment
    
    * migrate to kvstore and not persistent
    
    * remove unused func
    
    * test persistent
    
    Co-authored-by: Callum Waters <cmwaters19@gmail.com>
    tac0turtle and cmwaters authored Jul 12, 2021
    Configuration menu
    Copy the full SHA
    363ea56 View commit details
    Browse the repository at this point in the history
  3. Revert "statesync: keep peer despite lightblock query fail (#6692)" (…

    …#6696)
    
    * Revert "statesync: keep peer despite lightblock query fail (#6692)"
    
    This reverts commit 50b00df.
    williambanfield authored Jul 12, 2021
    Configuration menu
    Copy the full SHA
    cabd916 View commit details
    Browse the repository at this point in the history
  4. statesync: remove outgoingCalls race condition in dispatcher (#6699)

    * statesync: remove outgoing calls race condition
    williambanfield authored Jul 12, 2021
    Configuration menu
    Copy the full SHA
    4009102 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. build(deps): Bump github.com/google/uuid from 1.2.0 to 1.3.0 (#6708)

    Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.2.0 to 1.3.0.
    - [Release notes](https://github.com/google/uuid/releases)
    - [Commits](google/uuid@v1.2.0...v1.3.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/google/uuid
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    11bebfb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a12e2bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8228936 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab5c63e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    36a859a View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Configuration menu
    Copy the full SHA
    40fba39 View commit details
    Browse the repository at this point in the history
  2. statesync: dispatcher test uses internal channel for timing (#6713)

    This code change amends the dispatcher tests to read from the dispatcher's `requestCh`. This ensures that a request is waiting when the test calls `dispatcher.respond`. 
    addresses: #6711
    williambanfield authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    a46724e View commit details
    Browse the repository at this point in the history
  3. docs: fix broken links (#6719)

    ## Description 
    
    Fix broken links
    
    closes #6695
    tac0turtle authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    76c6c67 View commit details
    Browse the repository at this point in the history
  4. e2e: tweak sleep for pertubations (#6723)

    This tweaks sleeps around pertubations, based on a theory that our
    tests with "kill" pertubations restart the nodes fast enough the peers
    haven't marked it down when it tries to reconnect. In my local test
    runs, this clears out *most* of the test failures that I've seen,
    except for one evidence-related test-harness problem (which should be
    handled separately.)
    tychoish authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    8addf99 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. build(deps): Bump actions/stale from 3.0.19 to 4 (#6726)

    Bumps [actions/stale](https://github.com/actions/stale) from 3.0.19 to 4.
    - [Release notes](https://github.com/actions/stale/releases)
    - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
    - [Commits](actions/stale@v3.0.19...v4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/stale
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jul 15, 2021
    Configuration menu
    Copy the full SHA
    626d9b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6dd0cf9 View commit details
    Browse the repository at this point in the history
  3. RPC: mark grpc as deprecated (#6725)

    ## Description
    
    Mark gRPC as deprecated in the RPC layer. 
    
    closes #6718
    tac0turtle authored Jul 15, 2021
    Configuration menu
    Copy the full SHA
    4f88520 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. blockchain: error on v2 selection (#6730)

    ## Description
    
    Remove v2 flag from toml
    tac0turtle authored Jul 16, 2021
    Configuration menu
    Copy the full SHA
    78a0a5f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. Configuration menu
    Copy the full SHA
    fdc246e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. add and run make target for generating existing mocks (#6732)

    There are many `//go:generate mockery` lines in the source code.
    This change adds a make target to invoke these mock generations.
    This change also invokes the mock invocations and adds the resulting mocks to the repo.
    
    Related to #5274
    williambanfield authored Jul 18, 2021
    Configuration menu
    Copy the full SHA
    f70396c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Configuration menu
    Copy the full SHA
    21309cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68ffe8b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Configuration menu
    Copy the full SHA
    639e145 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2030875 View commit details
    Browse the repository at this point in the history
  3. fastsync/event: emit fastsync status event when switching consensus/f…

    …astsync (#6619)
    
    closes #2498 
    solves part of #3365
    
    Note: difficult to test the event emit in SwitchToFastSync part, might need to change `stateSyncReactor` to an interface in the `nodeImpl` struct
    JayT106 authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    c4f77ab View commit details
    Browse the repository at this point in the history
  4. e2e: remove cartesian testing of ipv6 (#6734)

    Having looked at our network address parsing and connection code, it
    really looks like we're not doing anything on top of what the standard
    library is doing (both in terms using `net.ParseIP` and also
    `net.Dial`,) and I don't think we need to run the tests 2x the number
    of times just to run through different areas of the standard
    library. I think most of our users are going to be using IPv4, and
    would be down to fully remove this dimension as well, if we find it's
    making noise, but for now I think it's fine.
    tychoish authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    00a4083 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ff9038e View commit details
    Browse the repository at this point in the history
  6. fix makefile test target to rely on test makefile (#6746)

    The Makefile at the root of the repo [includes](https://github.com/tendermint/tendermint/blob/cd19ef244efda1d666fe4e73b045f94dd5f646ff/Makefile#L61) the Makefile under the `test` package. This fix removes the target defined in the root Makefile in favor of the included one.
    williambanfield authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    0bf7813 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2abfe20 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7638235 View commit details
    Browse the repository at this point in the history
  9. build(deps): Bump codecov/codecov-action from 1.5.2 to 2.0.1 (#6739)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1.5.2 to 2.0.1.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
    - [Commits](codecov/codecov-action@v1.5.2...v2.0.1)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Sam Kleinman <garen@tychoish.com>
    dependabot[bot] and tychoish authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    7d63e99 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Configuration menu
    Copy the full SHA
    08e4e2e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    478f532 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Configuration menu
    Copy the full SHA
    e70445f View commit details
    Browse the repository at this point in the history
  2. mempool: return mempool errors to the abci client (#6740)

    This changes adds an `MempoolError` field to the `ResponseCheckTx`. This will allow clients to understand that their transaction was rejected from the mempool despite passing the ABCI check. 
    
    This change also updates the code to make use of early returns to prevent highly nested code blocks. Namely, it returns when the type assertion fails at the beginning of the method, instead of wrapping the entire method in a large if statement. This has a somewhat large effect on the diff as rendered by github.
    
    addresses: #3546
    williambanfield authored Jul 22, 2021
    Configuration menu
    Copy the full SHA
    84c1585 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97a8f12 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e2752a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Configuration menu
    Copy the full SHA
    a393cf8 View commit details
    Browse the repository at this point in the history
  2. p2p: add coverage for mConnConnection.TrySendMessage (#6754)

    This change adds additional coverage to the `mConnConnection.TrySendMessage` code path. Adds test to ensure it returns `io.EOF` when closed.
    
    Addresses: #6570
    williambanfield authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    c3ae6f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Configuration menu
    Copy the full SHA
    a341a62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91e277d View commit details
    Browse the repository at this point in the history
  3. build(deps): Bump codecov/codecov-action from 2.0.1 to 2.0.2 (#6764)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.1 to 2.0.2.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
    - [Commits](codecov/codecov-action@v2.0.1...v2.0.2)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Marko <marbar3778@yahoo.com>
    dependabot[bot] and tac0turtle authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    93f462e View commit details
    Browse the repository at this point in the history
  4. test/fuzz: add test to reproduce found fuzz errors (#6757)

    This change does two things:
    1. It fixes the json fuzzer to account for receiving array results. Arrays are returned by the rpc server when the input data is an array.
    2. Adds a `fuzz_test.go` file and corresponding `testdata` directory containing the failing test case.
    
    This seems like a reasonable way to add and track previous crash issues in our fuzz test cases. The upcoming stdlib go fuzz tool does effectively this automatically.
    williambanfield authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    c5dc3b2 View commit details
    Browse the repository at this point in the history
  5. p2p: add test for pqueue dequeue full error (#6760)

    This adds a test for closing the `pqueue` while the `pqueue` contains data that has not yet been dequeued.
    
    This issue was found while debugging #6705 
    
    This test will fail until @cmwaters fix for this condition is merged.
    williambanfield authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    a751eee View commit details
    Browse the repository at this point in the history
  6. test/fuzz: add mechanism to reproduce found fuzz errors (#6768)

    * test/fuzz: add test to reproduce found fuzz errors
    williambanfield authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    dd97ac6 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Configuration menu
    Copy the full SHA
    76376e3 View commit details
    Browse the repository at this point in the history
  2. abci: add changelog entry for mempool_error field (#6770)

    Follow up from PR: #6740
    williambanfield authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    44ac574 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a3861f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f73748 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e87b039 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Configuration menu
    Copy the full SHA
    6ff4c31 View commit details
    Browse the repository at this point in the history
  2. light: replace homegrown mock with mockery (#6735)

    This pull request removes the homegrown mocks in `light/provider/mock` in favor of mockery mocks.
    
    Adds a simple benchmark only mock to avoid the overhead of `reflection` that `mockery` incurs.
    
    part of #5274
    williambanfield authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    9e41414 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a94b55 View commit details
    Browse the repository at this point in the history
  4. cleanup: remove redundant error plumbing (#6778)

    This is a mostly-automated fixup using Comby (https://comby.dev) to remove 
    lexically-obvious redundant error checks. No functional changes are intended.
    
    To reproduce the core change:
    
        # Collapse redundant error check conditionals
        % comby -in-place 'if err != nil {
           return err
        }
        return nil' 'return err' .go
    
        # Fold out unnecessary error temporaries
        % comby -in-place ':[spc~^\s*]err :[~:?]= :[any]
           return err' ':[spc]return :[any]' .go
    
    Fixes #6479 and related cases.
    creachadair authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8f06e0c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Configuration menu
    Copy the full SHA
    9a2a7d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Fix and clarify breaks from select cases. (#6781)

    Update those break statements inside case clauses that are intended to reach an
    enclosing for loop, so that they correctly exit the loop.
    
    The candidate files for this change were located using:
    
        % staticcheck -checks SA4011 ./... | cut -d: -f-2
    
    This change is intended to preserve the intended semantics of the code, but
    since the code as-written did not have its intended effect, some behaviour may
    change. Specifically: Some loops may have run longer than they were supposed
    to, prior to this change.
    
    In one case I was not able to clearly determine the intended outcome. That case
    has been commented but otherwise left as-written.
    
    Fixes #6780.
    M. J. Fromberger authored Jul 30, 2021
    Configuration menu
    Copy the full SHA
    6dd8984 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3aec71c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    02f8e4c View commit details
    Browse the repository at this point in the history
  4. tools: add mockery to tools.go and remove mockery version strings (#6…

    …787)
    
    This change aims to keep versions of mockery consistent across developer laptops.
    
    This change adds mockery to the `tools.go` file so that its version can be managed consistently in the `go.mod` file.
    
    Additionally, this change temporarily disables adding mockery's version number to generated files. There is an outstanding issue against the mockery project related to the version string behavior when running from `go get`. I have created a pull request to fix this issue in the mockery project.
    see: vektra/mockery#397
    williambanfield authored Jul 30, 2021
    Configuration menu
    Copy the full SHA
    4e96c6b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. mempool/v1: test reactor does not panic on broadcast (#6772)

    This changes adds a failing test for issue #6660. It achieves this by adding a transaction, starting the `broadcastTxRoutine` in a goroutine and then adding another transaction to the mempool. The `broadcastTxRoutine` can receive the second inserted transaction before `insertTx` returns. In that case, `broadcastTxRoutine` will derefence a nil pointer when referencing the `gossipEl` and panic.
    williambanfield authored Aug 2, 2021
    Configuration menu
    Copy the full SHA
    dc7c212 View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump technote-space/get-diff-action from 4 to 5 (#6788)

    Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action) from 4 to 5.
    - [Release notes](https://github.com/technote-space/get-diff-action/releases)
    - [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc)
    - [Commits](technote-space/get-diff-action@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: technote-space/get-diff-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    dependabot[bot] and alexanderbez authored Aug 2, 2021
    Configuration menu
    Copy the full SHA
    e922016 View commit details
    Browse the repository at this point in the history
  3. docs: fix typo (#6789)

    renaynay authored Aug 2, 2021
    Configuration menu
    Copy the full SHA
    e5f9dd2 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. docs: fix a typo in the genesis_chunked description (#6792)

    M. J. Fromberger authored Aug 3, 2021
    Configuration menu
    Copy the full SHA
    4cbaf70 View commit details
    Browse the repository at this point in the history
  2. clist: add simple property tests (#6791)

    Adds a simple property test to the `clist` package. This test uses the [rapid](https://github.com/flyingmutant/rapid) library and works by modeling the internal clist as a simple array.
    
    Follow up from this mornings workshop with the Regen team.
    williambanfield authored Aug 3, 2021
    Configuration menu
    Copy the full SHA
    e801328 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. build(deps): Bump github.com/BurntSushi/toml from 0.3.1 to 0.4.1 (#6796)

    Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 0.3.1 to 0.4.1.
    - [Release notes](https://github.com/BurntSushi/toml/releases)
    - [Commits](BurntSushi/toml@v0.3.1...v0.4.1)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/BurntSushi/toml
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    4db71da View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. build(deps): Bump google.golang.org/grpc from 1.39.0 to 1.39.1 (#6801)

    Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.0 to 1.39.1.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p>
    <blockquote>
    <h2>Release 1.39.1</h2>
    <ul>
    <li>server: fix bug that net.Conn is leaked if the connection is closed (io.EOF) immediately with no traffic (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4642">#4642</a>)</li>
    <li>transport: fix race in transport stream accessing s.recvCompress (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4627">#4627</a>)</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/grpc/grpc-go/commit/db17d4b4adf4cbc1539baff45e63c837b889ff20"><code>db17d4b</code></a> Change version to 1.39.1 (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4651">#4651</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/8d1369b150686779abd1dc1dbd730a77214d63a0"><code>8d1369b</code></a> server: fix leaked net.Conn (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4642">#4642</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/2e0b66bb0ea2949dc731d2a3e82af2f6bcfd41eb"><code>2e0b66b</code></a> transport: fix race accessing s.recvCompress (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4627">#4627</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/db2d595725fc6f52b3bc31b957ce537a008c9290"><code>db2d595</code></a> Change version to 1.39.1-dev (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4542">#4542</a>)</li>
    <li>See full diff in <a href="https://github.com/grpc/grpc-go/compare/v1.39.0...v1.39.1">compare view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google.golang.org/grpc&package-manager=go_modules&previous-version=1.39.0&new-version=1.39.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    
    </details>
    dependabot[bot] authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    e531294 View commit details
    Browse the repository at this point in the history
  2. docs: upgrade documentation for custom mempools (#6794)

    This is proposed language for the upgrade process about the new custom
    reactor/mempool support.
    tychoish authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    31994ca View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Add new team member to CODEOWNERS. (#6811)

    M. J. Fromberger authored Aug 10, 2021
    Configuration menu
    Copy the full SHA
    a7ecf49 View commit details
    Browse the repository at this point in the history
  2. bytes: clean up and simplify encoding of HexBytes (#6810)

    As written, the encoding step unnecessarily made and moved multiple copies of
    the encoded representation. Reduce this to a single allocation and encode the
    data in-place so that a shift is no longer required.
    
    Also: Add a test to ensure letter digits are capitalized, which was previously not
    verified but was expected downstream.
    
    No functional changes.
    M. J. Fromberger authored Aug 10, 2021
    Configuration menu
    Copy the full SHA
    53d53e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66084a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Configuration menu
    Copy the full SHA
    9743513 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a6d20a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbfc04d View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. node: minimize hardcoded service initialization (#6798)

    * node: minimize hardcoded service initialization
    
    * hacking
    
    * nil safety
    
    * reduce space
    
    * remove genesis state store
    
    * fix lint
    
    * fix pex
    
    * unwind some odering effects
    
    * fix tests
    
    * remove unused experiment
    tychoish authored Aug 12, 2021
    Configuration menu
    Copy the full SHA
    d56a44b View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump google.golang.org/grpc from 1.39.1 to 1.40.0 (#6819)

    Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.1 to 1.40.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p>
    <blockquote>
    <h2>Release 1.40.0</h2>
    <h1>Behavior Changes</h1>
    <ul>
    <li>balancer: client channel no longer connects to idle subchannels that are returned by the pickers; LB policy should call SubConn.Connect instead. (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4579">#4579</a>)
    <ul>
    <li>This change is in line with existing documentation stating the balancer must call Connect on idle SubConns in order for them to connect, and is preparation for an upcoming change that transitions SubConns to the idle state when connections are lost.  See <a href="https://pkg.go.dev/google.golang.org/grpc/balancer#SubConn">https://pkg.go.dev/google.golang.org/grpc/balancer#SubConn</a> for more details.</li>
    </ul>
    </li>
    </ul>
    <h1>Bug Fixes</h1>
    <ul>
    <li>transport: fail RPCs without HTTP status 200 (OK), according to the gRPC spec (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4474">#4474</a>)
    <ul>
    <li>Special Thanks: <a href="https://github.com/JNProtzman"><code>@​JNProtzman</code></a></li>
    </ul>
    </li>
    <li>binarylog: fail the <code>Write()</code> method if proto marshaling fails (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4582">#4582</a>)
    <ul>
    <li>Special Thanks: <a href="https://github.com/Jille"><code>@​Jille</code></a></li>
    </ul>
    </li>
    <li>binarylog: exit the flusher goroutine upon closing the <code>bufferedSink</code> (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4583">#4583</a>)
    <ul>
    <li>Special Thanks: <a href="https://github.com/Jille"><code>@​Jille</code></a></li>
    </ul>
    </li>
    </ul>
    <h1>New Features</h1>
    <ul>
    <li>metadata: add Delete method to MD to encapsulate lowercasing (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4549">#4549</a>)
    <ul>
    <li>Special Thanks: <a href="https://github.com/konradreiche"><code>@​konradreiche</code></a></li>
    </ul>
    </li>
    <li>xds/cds: support logical DNS cluster and aggregated cluster (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4594">#4594</a>)</li>
    <li>stats: add stats.Begin.IsClientStream and IsServerStream to indicate the type of RPC invoked (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4533">#4533</a>)
    <ul>
    <li>Special Thanks: <a href="https://github.com/leviska"><code>@​leviska</code></a></li>
    </ul>
    </li>
    </ul>
    <h1>Performance Improvements</h1>
    <ul>
    <li>server: improve performance when multiple interceptors are used (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4524">#4524</a>)
    <ul>
    <li>Special Thanks: <a href="https://github.com/amenzhinsky"><code>@​amenzhinsky</code></a></li>
    </ul>
    </li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/grpc/grpc-go/commit/41e044e1c82fcf6a5801d6cbd7ecf952505eecb1"><code>41e044e</code></a> server: fix leaked net.Conn (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4644">#4644</a>) (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4670">#4670</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/1634fd3fc38c505906f929b1f1f73a24571a042e"><code>1634fd3</code></a> Change version to 1.40.0 (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4623">#4623</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/b1a15ac3703c03e1a01607360e8b835a28b02369"><code>b1a15ac</code></a> server: fix leaked net.Conn (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4644">#4644</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/00edd8c13a7a27bc25c8de2a68cf6de35f88bd7e"><code>00edd8c</code></a> Add xDS k8s url-map test Kokoro job (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4614">#4614</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/1ddab338690a578975747239ad4ecd2ae63b1965"><code>1ddab33</code></a> client: fix detection of whether IO was performed in NewStream (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4611">#4611</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/582ef458c6d8174087877ee83bb514abc16650a5"><code>582ef45</code></a> cluster_resolver: move balancer config types into cluster_resolver package an...</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/c513103bee39e1ebc3793e7128941794667779de"><code>c513103</code></a> Add extra layer on top of RBAC Engine (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4576">#4576</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/a0bed723f1c00c8b07c6ceaf1f6ac2cb42ec0b35"><code>a0bed72</code></a> xds: add http filters to FilterChain matching (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4595">#4595</a>)</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/0a8c63739a87bee6ff6097d272b63727659f4503"><code>0a8c637</code></a> grpclb: propagate the most recent connection error when grpclb enters transie...</li>
    <li><a href="https://github.com/grpc/grpc-go/commit/8332d5b997af9e1554418167860351696d35e628"><code>8332d5b</code></a> test: fix possible goroutine leaks in unit tests (<a href="https://github-redirect.dependabot.com/grpc/grpc-go/issues/4570">#4570</a>)</li>
    <li>Additional commits viewable in <a href="https://github.com/grpc/grpc-go/compare/v1.39.1...v1.40.0">compare view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google.golang.org/grpc&package-manager=go_modules&previous-version=1.39.1&new-version=1.40.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    
    </details>
    dependabot[bot] authored Aug 12, 2021
    Configuration menu
    Copy the full SHA
    1f76cb1 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. doc: fix typos in /tx_search and /tx. (#6823)

    Just a few small typos in the descriptions of the /tx_search and /tx endpoints.
    crodriguezvega authored Aug 13, 2021
    Configuration menu
    Copy the full SHA
    511e52c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf77c0c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. rpc: log update (#6825)

    We INFO log every `ABCIQuery`. This can output a tremendous amount of noise in the logs, can cause cosmovisor to completely crash and slows down the node due to I/O. This log is completely unnecessary.
    
    Let's get this backported into v0.43 and get that into v0.43 and v0.42 releases of the SDK
    
    
    /cc @marbar3778
    alexanderbez authored Aug 14, 2021
    Configuration menu
    Copy the full SHA
    393a02a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Configuration menu
    Copy the full SHA
    471f83d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    267aac2 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Configuration menu
    Copy the full SHA
    0ed3ba6 View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump github.com/golangci/golangci-lint (#6837)

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.41.1 to 1.42.0.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.41.1...v1.42.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 18, 2021
    Configuration menu
    Copy the full SHA
    afb6af8 View commit details
    Browse the repository at this point in the history
  3. changelog: linkify the 0.34.11 release notes (#6836)

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    tessr and alexanderbez authored Aug 18, 2021
    Configuration menu
    Copy the full SHA
    69f6eee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a4cc831 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. docs: add package godoc for indexer (#6839)

    * docs: add indexer godoc
    
    * docs++
    
    * docs++
    
    * docs++
    
    * docs++
    
    * docs++
    
    * Update state/indexer/doc.go
    
    Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
    
    * Update state/indexer/doc.go
    
    Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
    
    * Update state/indexer/doc.go
    
    Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
    
    * Update state/indexer/doc.go
    
    Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
    
    * Update state/indexer/doc.go
    
    Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
    
    * Update state/indexer/doc.go
    
    Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
    
    * docs++
    
    Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
    alexanderbez and M. J. Fromberger authored Aug 19, 2021
    Configuration menu
    Copy the full SHA
    cce0a3c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. build(deps): Bump docker/build-push-action from 2.6.1 to 2.7.0 (#6845)

    Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2.6.1 to 2.7.0.
    - [Release notes](https://github.com/docker/build-push-action/releases)
    - [Commits](docker/build-push-action@v2.6.1...v2.7.0)
    
    ---
    updated-dependencies:
    - dependency-name: docker/build-push-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 20, 2021
    Configuration menu
    Copy the full SHA
    3a234e1 View commit details
    Browse the repository at this point in the history
  2. e2e: cleanup node start function (#6842)

    I realized after my last commit that my change made a following line of code a bit redundant.
    
    (alternatively my last change was redunadnt to the existing code.)
    
    I took this oppertunity to make some minor cleanups and logging changes to the node changes which I hope will make tests a bit more clear.
    tychoish authored Aug 20, 2021
    Configuration menu
    Copy the full SHA
    a374f74 View commit details
    Browse the repository at this point in the history
  3. ADR 071: Proposer-based Timestamps (#6799)

    Architectural decision record for Proposer-based timestamps.
    williambanfield authored Aug 20, 2021
    Configuration menu
    Copy the full SHA
    8700ca9 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Configuration menu
    Copy the full SHA
    d0e33b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39dee8a View commit details
    Browse the repository at this point in the history
  3. ADR 072: Re-instate a request-for-comments archive. (#6851)

    This ADR restores a variation of the old Request for Comments documentation
    that we previously used. The proposal differs from the original formulation,
    and does not replace ADRs.
    M. J. Fromberger authored Aug 23, 2021
    Configuration menu
    Copy the full SHA
    ce3c059 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. time: make median time library type private (#6853)

    This is a very minor change, but I was looking through the code, and
    this seems like it shouldn't be exported or used more broadly, so I've
    moved it out.
    tychoish authored Aug 24, 2021
    Configuration menu
    Copy the full SHA
    d7c3a8f View commit details
    Browse the repository at this point in the history
  2. cmd: remove deprecated snakes (#6854)

    just following up on a deprecation.
    tychoish authored Aug 24, 2021
    Configuration menu
    Copy the full SHA
    d8642a9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6d5ff59 View commit details
    Browse the repository at this point in the history
  4. inspect: add inspect mode for debugging crashed tendermint node (#6785)

    EDIT: Updated, see [comment below]( tendermint/tendermint#6785 (comment))
    
    This change adds a sketch of the `Debug` mode. 
    
    This change adds a `Debug` struct to the node package. This `Debug` struct is intended to be created and started by a command in the `cmd` directory. The `Debug` struct runs the RPC server on the data directories: both the state store and the block store.
    
    This change required a good deal of refactoring. Namely, a new `rpc.go` file was added to the `node` package. This file encapsulates functions for starting RPC servers used by nodes. A potential additional change is to further factor this code into shared code _in_ the `rpc` package. 
    
    Minor API tweaks were also made that seemed appropriate such as the mechanism for fetching routes from the `rpc/core` package.
    
    Additional work is required to register the `Debug` service as a command in the `cmd` directory but I am looking for feedback on if this direction seems appropriate before diving much further.
    
    closes: #5908
    williambanfield authored Aug 24, 2021
    Configuration menu
    Copy the full SHA
    bc2b529 View commit details
    Browse the repository at this point in the history
  5. psql: add documentation and simplify constructor API (#6856)

    Add documentation comments to the psql event sink package, and simplify the
    constructor function so that it does not return the SQL database handle.  The
    handle is needed for testing, so expose that via a separate method on the
    concrete type.
    
    Update the tests and existing usage for the change. This change does not affect
    the behaviour of the sink, so there are no functional changes, only syntactic
    updates.
    M. J. Fromberger authored Aug 24, 2021
    Configuration menu
    Copy the full SHA
    41a361e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. build(deps): Bump codecov/codecov-action from 2.0.2 to 2.0.3 (#6860)

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.2 to 2.0.3.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
    - [Commits](codecov/codecov-action@v2.0.2...v2.0.3)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    e053643 View commit details
    Browse the repository at this point in the history
  2. e2e: more consistent node selection during tests (#6857)

    In the transaction load generator, the e2e test harness previously distributed load randomly to hosts, which was a source of test non-determinism. This change distributes the load generation to the different nodes in the set in a round robin fashion, to produce more reliable results, but does not otherwise change the behavior of the test harness.
    tychoish authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    9c8379e View commit details
    Browse the repository at this point in the history
  3. lint: change deprecated linter (#6861)

    This is a super minor change that silences a warning when running the linter locally.
    tychoish authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    a0a5d45 View commit details
    Browse the repository at this point in the history
  4. p2p: change default to use new stack (#6862)

    This is just a configuration change to default to using the new stack
    unless explicitly disabled (e.g. `UseLegacy`) this renames the
    configuration value and makes the configuration logic more clear.
    
    The legacy option is good to retain as a fallback if the new stack has
    issues operationally, but we should make sure that most of the time
    we're using the new stack.
    tychoish authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    6e921f6 View commit details
    Browse the repository at this point in the history
  5. internal/consensus: update error log (#6863)

    Issues reported in Osmosis, where the message is extremely long. Also, there is absolutely no reason to log the message IMO. If we must, we can make the message log DEBUG.
    alexanderbez authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    58a6cff View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. rfc: p2p next steps (#6866)

    tychoish authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    23abb0d View commit details
    Browse the repository at this point in the history
  2. rfc: fix link style (#6870)

    This is super minor, but chaning this to fix a broken link and to
    match the existing style of the ADRs.
    tychoish authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    94e1eb8 View commit details
    Browse the repository at this point in the history
  3. e2e: add weighted random configuration selector (#6869)

    When revwing #6807 I assumed that `probSetChoice` worked this way. 
    
    I think that the coverage of various configuration options should
    generally track what we expect the actual useage to be to focus the
    most test coverage on the configurations that are the most prevelent.
    tychoish authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    0df421b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. docs: remove return code in normal case from go built-in example (#6841)

    An explicit exit prevents the deferred cleanup code from running. In this case,
    falling off the end of main will achieve the same goal as an explicit exit.
    conr2d authored Aug 29, 2021
    Configuration menu
    Copy the full SHA
    c9347a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. build(deps): Bump github.com/rs/zerolog from 1.23.0 to 1.24.0 (#6874)

    Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.23.0 to 1.24.0.
    - [Release notes](https://github.com/rs/zerolog/releases)
    - [Commits](rs/zerolog@v1.23.0...v1.24.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/rs/zerolog
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    f858ebe View commit details
    Browse the repository at this point in the history
  2. types: move mempool error for consistency (#6875)

    This is a little change just to make things more consistent ahead of
    the 0.35 release.
    tychoish authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    c4df8a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. e2e: more reliable method for selecting node to inject evidence (#6880)

    In retrospect my previous implementation of this node, could get
    unlucky and never find the correct node. This method is more reliable.
    tychoish authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    7169d26 View commit details
    Browse the repository at this point in the history
  2. Update the psql indexer schema and implementation (#6868)

    Update the schema and implementation of the Postgres event indexer to improve 
    certain types of queries against the index. These changes address the use cases
    raised by #6843, and are partly inspired by the prototype schema in that issue.
    
    In the old schema, events were flattened, making it difficult to find all the events 
    associated with a particular block or transaction. In addition, events with no key/value
    attributes were entirely lost, since entries were generated only for attributes.
    
    To address these issues, this new schema records blocks, transactions, events,
    and attributes in separate tables, and provides views that join these tables to
    give a more convenient query surface for block and transaction events.
    
    - All events for a given block can be queried from the `block_events` view.
    - All events for a given transaction can be queried from the `tx_events` view.
    - Multiple events for the same key can be indexed for both blocks and transactions.
    
    The tests have been reworked, but all of the existing test cases for the old schema 
    still pass with the new implementation. Various other minor cleanups are included,
    
    ADR-065 is also updated to reflect the updated schema.
    M. J. Fromberger authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    7fe3e78 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Configuration menu
    Copy the full SHA
    9a0081f View commit details
    Browse the repository at this point in the history
  2. e2e: weight protocol dimensions (#6884)

    This changes the focus of the e2e suite, to (roughly) focus on
    configurations that are more well used. Most production users of
    tendermint run ABCI application in process and the GRPC/socket methods
    cover the vast majority of the remaining use cases. 
    
    Perhaps we should consider drop support unix domain sockets in a
    future release, but I think in the mean time it's useful to have the
    tests *mostly* focus on the primary use cases.
    tychoish authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    511bd3e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Configuration menu
    Copy the full SHA
    bda948e View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. build(deps): Bump github.com/lib/pq from 1.10.2 to 1.10.3 (#6890)

    Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.10.2 to 1.10.3.
    - [Release notes](https://github.com/lib/pq/releases)
    - [Commits](lib/pq@v1.10.2...v1.10.3)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/lib/pq
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    0055f9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21b5e59 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    77615b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1f8bb74 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Configuration menu
    Copy the full SHA
    5ee39f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bab061 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    89539d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Configuration menu
    Copy the full SHA
    8fe651b View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump github.com/golangci/golangci-lint (#6907)

    Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.42.0 to 1.42.1.
    - [Release notes](https://github.com/golangci/golangci-lint/releases)
    - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
    - [Commits](golangci/golangci-lint@v1.42.0...v1.42.1)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/golangci/golangci-lint
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    04cca01 View commit details
    Browse the repository at this point in the history
  3. doc: fix a typo in the indexing section (#6909)

    M. J. Fromberger authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    db6e031 View commit details
    Browse the repository at this point in the history
  4. cleanup: fix order of linters in the golangci-lint config (#6910)

    This is a cosmetic change that restores lexicographic order to the selected
    linters in the CI config. No change to which linters we run, only putting them
    back in order so it's easier to spot the one you care about.
    M. J. Fromberger authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    cfe64ed View commit details
    Browse the repository at this point in the history
  5. update changelog ahead of v0.35 release (#6893)

    This change moves the changelog entries from CHANGELOG_PENDING.md to CHANGELOG.md ahead of the 0.35 release.
    williambanfield authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    9b458a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. upgrading: add information into the UPGRADING.md for users of the cod…

    …ebase wishing to upgrade (#6898)
    
    * add information on upgrading to the new p2p library
    
    * clarify p2p backwards compatibility
    
    * reorder p2p queue list
    
    * add demo for p2p selection
    
    * fix spacing in upgrading
    williambanfield authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    63aeb50 View commit details
    Browse the repository at this point in the history
  2. rename configuration parameters to use the new blocksync nomenclature…

    … (#6896)
    
    The 0.35 release cycle renamed the 'fastsync' functionality to 'blocksync'. This change brings the configuration parameters in line with that change. Namely, it updates the configuration file `[fastsync]` field to be `[blocksync]` and changes the command line flag and config file parameters `--fast-sync` and `fast-sync` to `--enable-block-sync` and `enable-block-sync` respectively.
    
    Error messages were added to help users encountering these changes be able to quickly make the needed update to their files/scripts.
    
    When using the old command line argument for fast-sync, the following is printed
    
    ```
    ./build/tendermint start --proxy-app=kvstore --consensus.create-empty-blocks=false --fast-sync=false
    ERROR: invalid argument "false" for "--fast-sync" flag: --fast-sync has been deprecated, please use --enable-block-sync
    ```
    
    When using one of the old config file parameters, the following is printed:
    ```
    ./build/tendermint start --proxy-app=kvstore --consensus.create-empty-blocks=false
    ERROR: error in config file: a configuration parameter named 'fast-sync' was found in the configuration file. The 'fast-sync' parameter has been renamed to 'enable-block-sync', please update the 'fast-sync' field in your configuration file to 'enable-block-sync'
    ```
    williambanfield authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    dc0e04d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a74c9c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Configuration menu
    Copy the full SHA
    2a224fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    816e9b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c3601b View commit details
    Browse the repository at this point in the history
  4. rpc: fix hash encoding in JSON parameters (#6813)

    The responses from node RPCs encode hash values as hexadecimal strings. This
    behaviour is stipulated in our OpenAPI documentation. In some cases, however,
    hashes received as JSON parameters were being decoded as byte buffers, as is
    the convention for JSON.
    
    This resulted in the confusing situation that a hash reported by one request
    (e.g., broadcast_tx_commit) could not be passed as a parameter to another
    (e.g., tx) via JSON, without translating the hex-encoded output hash into the
    base64 encoding used by JSON for opaque bytes.
    
    Fixes #6802.
    M. J. Fromberger authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    db690c3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1a9bad9 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Configuration menu
    Copy the full SHA
    af71f1c View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump github.com/rs/zerolog from 1.24.0 to 1.25.0 (#6923)

    Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.24.0 to 1.25.0.
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/rs/zerolog/commit/65adfd88ecb983005c9f735d207e11d63216ca00"><code>65adfd8</code></a> Make Fields method accept both map and slice (<a href="https://github-redirect.dependabot.com/rs/zerolog/issues/352">#352</a>)</li>
    <li>See full diff in <a href="https://github.com/rs/zerolog/compare/v1.24.0...v1.25.0">compare view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/rs/zerolog&package-manager=go_modules&previous-version=1.24.0&new-version=1.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    
    </details>
    dependabot[bot] authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    5d279c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f1b9613 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c3bcf9b View commit details
    Browse the repository at this point in the history
  5. e2e: compile tests (#6926)

    tychoish authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    1998cf7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    055f1b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. e2e: improve p2p mode selection (#6929)

    The previous implemention of hybrid set testing, which was entirely my
    own creation, was a bit peculiar, and I think this probably clears thins up.
    
    The previous implementation had far fewer legacy nodes in hybrid
    networks, *and* also for some reason that I can't quite explain,
    caused a test case to fail.
    tychoish authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    3bf0c7a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Configuration menu
    Copy the full SHA
    ef79241 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    723bf92 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abbe820 View commit details
    Browse the repository at this point in the history
  4. Update CHANGELOG.md for release v0.34.13. (#6935)

    Fixes #6933. I forgot to update master after I did the v0.34.13 release.
    M. J. Fromberger authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    e4feb56 View commit details
    Browse the repository at this point in the history
  5. RFC 002 Interprocess Communication in Tendermint (#6913)

    Communication in Tendermint among consensus nodes, applications, and operator
    tools all use different message formats and transport mechanisms.  In some
    cases there are multiple options. Having all these options complicates both the
    code and the developer experience, and hides bugs. To support a more robust,
    trustworthy, and usable system, we should document which communication paths
    are essential, which could be removed or reduced in scope, and what we can
    improve for the most important use cases.
    
    This document proposes a variety of possible improvements of varying size and
    scope. Specific design proposals should get their own documentation.
    M. J. Fromberger authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    5a49d1b View commit details
    Browse the repository at this point in the history
  6. e2e: slow load processes with longer evidence timeouts (#6936)

    These are mostly the timeouts that I think we're still hitting in CI. 
    
    At this point, the tests (on master) pass on my local machine (which is quite beefy) so I think this is just the first in (perhaps?) a sequence of changes that attempt to change timeouts and load patterns so that the tests pass in CI more reliably.
    tychoish authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    c257cda View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Configuration menu
    Copy the full SHA
    de2cffe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6909158 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Configuration menu
    Copy the full SHA
    5db2a39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e932b46 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f08f72e View commit details
    Browse the repository at this point in the history
  4. docs: fix openapi yaml lint (#6948)

    saw this in the super lint.
    tychoish authored Sep 15, 2021
    Configuration menu
    Copy the full SHA
    b9c35c1 View commit details
    Browse the repository at this point in the history
  5. e2e: skip broadcastTxCommit check (#6949)

    I think the `Sync` check covers our primary use case, and perhaps we
    can turn this back on in the future after some kind of event-system
    rewrite, or RPC rewrite that will avoid the serverside timeout.
    tychoish authored Sep 15, 2021
    Configuration menu
    Copy the full SHA
    55f6d20 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Configuration menu
    Copy the full SHA
    9a7ce08 View commit details
    Browse the repository at this point in the history
  2. rfc: add performance taxonomy rfc (#6921)

    This document attempts to capture and discuss some of the areas of Tendermint that seem to be cited as causing performance issue. I'm hoping to continue to gather feedback and input on this document to better understand what issues Tendermint performance may cause for our users. 
    
    The overall goal of this document is to allow the maintainers and community to get a better sense of these issues and to be more capably able to discuss them and weight trade-offs about any proposed performance-focused changes. This document does not aim to propose any performance improvements. It does suggest useful places for benchmarks and places where additional metrics would be useful for diagnosing and further understanding Tendermint performance.
    
    Please comment with areas where my reasoning seems off or with additional areas that Tendermint performance may be causing user pain.
    williambanfield authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    382947c View commit details
    Browse the repository at this point in the history
  3. build(deps): Bump github.com/vektra/mockery/v2 from 2.9.0 to 2.9.3 (#…

    …6951)
    
    Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.9.0 to 2.9.3.
    - [Release notes](https://github.com/vektra/mockery/releases)
    - [Changelog](https://github.com/vektra/mockery/blob/master/.goreleaser.yml)
    - [Commits](vektra/mockery@v2.9.0...v2.9.3)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/vektra/mockery/v2
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    b0684bd View commit details
    Browse the repository at this point in the history
  4. e2e: allow load generator to succed for short tests (#6952)

    This should address last night's failure. We've taken the perspective
    of "the load generator shouldn't cause tests to fail" in recent
    days/weeks, and I think this is just a next step along that line. The
    e2e tests shouldn't test performance. 
    
    I included some comments indicating the ways that this isn't ideal (it
    is perhaps not), and I think that if test networks could make
    assertions about the required rate, that might be a cool future
    improvement (and good, perhaps, for system benchmarking.)
    tychoish authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    b0423e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. e2e: cleanup on all errors if preserve not specified (#6950)

    If the e2e tests error, they leave all of the e2e state around including containers and networks etc. 
    We should clean this up when the tests shuts down, even if it exits in error.
    williambanfield authored Sep 17, 2021
    Configuration menu
    Copy the full SHA
    bf9232e View commit details
    Browse the repository at this point in the history
  2. build(deps): Bump github.com/vektra/mockery/v2 from 2.9.3 to 2.9.4 (#…

    …6956)
    
    Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.9.3 to 2.9.4.
    - [Release notes](https://github.com/vektra/mockery/releases)
    - [Changelog](https://github.com/vektra/mockery/blob/master/.goreleaser.yml)
    - [Commits](vektra/mockery@v2.9.3...v2.9.4)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/vektra/mockery/v2
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Sep 17, 2021
    Configuration menu
    Copy the full SHA
    ea6eecb View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Configuration menu
    Copy the full SHA
    ad067d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    079be9b View commit details
    Browse the repository at this point in the history
  3. use celestia specific readme (#529)

    * Modify README.md
    
     - summarize LL and why it's useful
     - add banner
     - add further resources
    
    * Delet tokei.rs link
    
    seems down
    
    * Update README.md
    
    * Update community link
    
    * Update readme Go version badge.
    
    * Update community link
    
    * Update readme Go version badge.
    
    * Rebranding (#415)
    
    * new logo
    
    * Update README.md
    
    * review feedback
    
    * remove install + quick start sections as links are broken
    
    * finish rebrand and update golang
    
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    Co-authored-by: Mustafa Al-Bassam <mustafa@lazyledger.io>
    Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
    Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
    5 people committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c4853e4 View commit details
    Browse the repository at this point in the history
  4. add celestia specific consts (#530)

    * Move consts, ipfs, and ipld to pkg (#508)
    
    * move ipfs and ipld packages to new pkg/da/
    
    * moved consts to pkg
    
    * clean up
    
    * go mod tidy
    evan-forbes committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    fcc5772 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    87b876a View commit details
    Browse the repository at this point in the history
  6. Refactor how to create DataAvailabilityHeaders (#524)

    * use [][]byte instead of interval digests
    
    * add extra DAH methods
    
    * move the dataavailabilityheader from types to da
    
    * refactor creating DAHs
    
    * finish refactor and clean up
    
    * add tests
    
    * linter
    
    * typos causing tests to fail
    
    * fix docs
    
    * remove test used while debugging
    
    * add docs to indicate that computing the shares also padds them
    
    * update to the latest version of nmt
    
    * change version of checkout to hopefully fix the proto lint ci test
    
    * update hashes to account for new verison of nmt
    
    add refactored DAH and nmt wrapper
    evan-forbes committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d6212d0 View commit details
    Browse the repository at this point in the history
  7. build(deps): Bump github.com/spf13/viper from 1.8.1 to 1.9.0 (#6961)

    Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.8.1 to 1.9.0.
    - [Release notes](https://github.com/spf13/viper/releases)
    - [Commits](spf13/viper@v1.8.1...v1.9.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/spf13/viper
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Sam Kleinman <garen@tychoish.com>
    dependabot[bot] and tychoish authored Sep 20, 2021
    Configuration menu
    Copy the full SHA
    cf59b8b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9dfdc62 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Configuration menu
    Copy the full SHA
    84ffaaa View commit details
    Browse the repository at this point in the history
  2. config/docs: update and deprecated (#6879)

    ## Description
    
    - Add deprecated to config values in toml
    - update config in configuration doc
    - explain how to set up a node with the new network
    
    - add sentence about not needing to fork tendermint for built-in tutorial
     - closes #6865 
    - add note to use a released version of tendermint with the tutorials. This is to avoid unknown issues prior to a release.
    tac0turtle authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    df2d744 View commit details
    Browse the repository at this point in the history
  3. readme: update discord links (#6965)

    This updates the Discord invite links.
    darika-dev authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    0f53a59 View commit details
    Browse the repository at this point in the history
  4. rfc: event system (#6957)

    tychoish authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    5a13c70 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Configuration menu
    Copy the full SHA
    07d1018 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6383465 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c4950d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d04b6c2 View commit details
    Browse the repository at this point in the history
  5. rpc: Strip down the base RPC client interface. (#6971)

    * rpc: Strip down the base RPC client interface.
    
    Prior to this change, the RPC client interface requires implementing the entire
    Service interface, but most of the methods of Service are not needed by the
    concrete clients. Dissociate the Client interface from the Service interface.
    
    - Extract only those methods of Service that are necessary to make the existing
      clients work.
    
    - Update the clients to combine Start/Onstart and Stop/OnStop. This does not
      change what the clients do to start or stop. Only the websocket clients make
      use of this functionality anyway.
    
      The websocket implementation uses some plumbing from the BaseService helper.
      We should be able to excising that entirely, but the current interface
      dependencies among the clients would require a much larger change, and one
      that leaks into other (non-RPC) packages.
    
      As a less-invasive intermediate step, preserve the existing client behaviour
      (and tests) by extracting the necessary subset of the BaseService
      functionality to an analogous RunState helper for clients. I plan to obsolete
      that type in a future PR, but for now this makes a useful waypoint.
    
    Related:
    - Clean up client implementations.
    - Update mocks.
    M. J. Fromberger authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    1995ef2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Remove the unused rpc/client/mocks package. (#6974)

    This package is not used in the tendermint repository since 31e7cde.
    
    Note that this is not the same package as rpc/client/mock (N.B. singular) which
    is still used in some tests.
    
    A search of GitHub turns up only 11 uses, all of which are in clones of the
    tendermint repo at old commits..
    M. J. Fromberger authored Sep 23, 2021
    Configuration menu
    Copy the full SHA
    7e4cc59 View commit details
    Browse the repository at this point in the history
  2. Fix script paths in go:generate directives. (#6973)

    We moved some files further down in the directory structure in #6964, which
    caused the relative paths to the mockery wrapper to stop working.
    
    There does not seem to be an obvious way to get the module root as a default
    environment variable, so for now I just added the extra up-slashes.
    M. J. Fromberger authored Sep 23, 2021
    Configuration menu
    Copy the full SHA
    41ac5b9 View commit details
    Browse the repository at this point in the history
  3. proto: regenerate code (#6977)

    ## Description
    
    Replace all seemed to have been used causing proto files to be changed without being regenerated
    tac0turtle authored Sep 23, 2021
    Configuration menu
    Copy the full SHA
    c9beef7 View commit details
    Browse the repository at this point in the history
  4. cleanup: Reduce and normalize import path aliasing. (#6975)

    The code in the Tendermint repository makes heavy use of import aliasing.
    This is made necessary by our extensive reuse of common base package names, and
    by repetition of similar names across different subdirectories.
    
    Unfortunately we have not been very consistent about which packages we alias in
    various circumstances, and the aliases we use vary. In the spirit of the advice
    in the style guide and https://github.com/golang/go/wiki/CodeReviewComments#imports,
    his change makes an effort to clean up and normalize import aliasing.
    
    This change makes no API or behavioral changes. It is a pure cleanup intended
    o help make the code more readable to developers (including myself) trying to
    understand what is being imported where.
    
    Only unexported names have been modified, and the changes were generated and
    applied mechanically with gofmt -r and comby, respecting the lexical and
    syntactic rules of Go.  Even so, I did not fix every inconsistency. Where the
    changes would be too disruptive, I left it alone.
    
    The principles I followed in this cleanup are:
    
    - Remove aliases that restate the package name.
    - Remove aliases where the base package name is unambiguous.
    - Move overly-terse abbreviations from the import to the usage site.
    - Fix lexical issues (remove underscores, remove capitalization).
    - Fix import groupings to more closely match the style guide.
    - Group blank (side-effecting) imports and ensure they are commented.
    - Add aliases to multiple imports with the same base package name.
    M. J. Fromberger authored Sep 23, 2021
    Configuration menu
    Copy the full SHA
    cf7537e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb8ffcb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8a171b8 View commit details
    Browse the repository at this point in the history
  7. Basic DA functionality (#83)

    * move Messages field to the end of Block.Data
    
    * Add some constants for share computation and the NMT:
    
     - also a bunch of todos regarding shares computation
    
    * First (compiling) stab on creating shares
    
    * Test with Evidence and fix bug discovered by test
    
    * remove resolved todos
    
    * introduce split method
    
    * Introduce LenDelimitedMarshaler interface and some reformatting
    
    * Introduce TxLenDelimitedMarshaler
    
    * add some test cases
    
    * fix some comments
    
    * fix some comments & linter
    
    * Add reserved namespaces to params
    
    * Move ll-specific consts into a separate file (consts.go)
    
    * Add MarshalDelimited to HexBytes
    
    * Add tail-padding shares
    
    * Add ComputeShares method on Data to compute all shares
    
    * Fix compute the next square num and not the next power of two
    
    * lints
    
    * Unexport MakeShares function:
    
    - it's likely to change and it doesn't have to be part of the public API
    
    * lints 2
    
    * First stab on computing row/column roots
    
    * fix rebase glitches:
     - move DA related constants out of params.go
    
    * refactor MakeBlock to take in interm. state roots and messages
    
    * refactor state.MakeBlock too
    
    * Add todos LenDelimitedMarshaler and extract appendShares logic
    
    * Simplify shares computation: remove LenDelimitedMarshaler abstraction
    
    * actually use DA header to compute the DataRoot everywhere (will lead to failing tests for sure)
    
    * WIP: Update block related core data structures in protobuf too
    
    * WIP: fix zero shares edge-case and get rid of Block.Data.hash (use dataAvailabilityHeader.Hash() instead)
    
    * Fixed tests, only 3 failing tests to go: TestReapMaxBytesMaxGas, TestTxFilter, TestMempoolFilters
    
    * Fix TestTxFilter:
    
     - the size of the wrapping Data{} proto message increased a few bytes
    
    * Fix Message proto and `DataFromProto`
    
    * Fix last 2 remaining tests related to the increased block/block.Data size
    
    * Use infectious lib instead of leopard
    
    * proto-lint: snake_case
    
    * some lints and minor changes
    
    * linter
    
    * panic if pushing to tree fails, extend Data.ToProto()
    
    * revert renaming in comment
    
    * add todo about refactoring as soon as the rsmt2d allows the user to choose the merkle tree
    
    clean up some unused test helper functions
    
    linter
    
    still debugging the exact right number of bytes for max data...
    
    Implement spec-compliant share splitting (#246)
    
    * Export block data compute shares.
    * Refactor to use ShareSize constant directly.
    * Change message splitting to prefix namespace ID.
    * Implement chunking for contiguous.
    * Add termination condition.
    * Rename append contiguous to split contiguous.
    * Update test for small tx.
    * Add test for two contiguous.
    * Make tx and msg adjusted share sizes exported constants.
    * Panic on hopefully-unreachable condition instead of silently skipping.
    * Update hardcoded response for block format.
    
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    liamsi authored and evan-forbes committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    26aa942 View commit details
    Browse the repository at this point in the history
  8. fix overwrite bug (#251)

    * fix overwrite bug and stop splitting shares of size MsgShareSize
    
    * remove ineffectual code
    
    * review feedback: better docs
    
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    
    * remove uneeded copy and only fix the source of the bug
    
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    
    * fix overwrite bug while also being consistent with using NamespacedShares
    
    * update to the latest rsmt2d for the nmt wrapper
    
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    evan-forbes and liamsi committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    12c8a7e View commit details
    Browse the repository at this point in the history
  9. Spec compliant merge shares (#261)

    * start spec compliant share merging
    
    * refactor and finish unit testing
    
    * whoops
    
    * linter gods
    
    * fix initial changes and use constants
    
    * use constant
    
    * more polish
    
    * docs fix* review feedback: docs and out of range panic protection
    
    * review feedback: add panic protection from empty input
    
    * use constant instead of recalculating `ShareSize`* don't redeclare existing var* be more explicit with returned nil* use constant instead of recalculating `ShareSize`* review feedback: use consistent capitalization
    
    * stop accepting reserved namespaces as normal messages
    
    * use a descriptive var name for message length
    
    * linter and comparison fix
    
    * reorg tests, add test for parse delimiter, DataFromBlock and fix evidence marshal bug
    
    * catch error for linter
    
    * update test MakeShares to include length delimiters for the SHARE_RESERVED_BYTE
    
    * minor iteration change
    
    * refactor share splitting to fix bug
    
    * fix all bugs with third and final refactor
    
    * fix conflict
    
    * revert unnecessary changes
    
    * review feedback: better docs* reivew feedback: add comment for safeLen
    
    * review feedback: remove unnecessay comments
    
    * review feedback: split up share merging and splitting into their own files
    
    * review feedback: more descriptive var names
    
    * fix accidental change
    
    * add some constant docs
    
    * spelling error
    
    Co-authored-by: Hlib Kanunnikov <hlibwondertab@gmail.com>
    Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    4 people committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    95489ee View commit details
    Browse the repository at this point in the history
  10. refactor to better accomodate real world use cases (celestia node)

    Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
    
    thank you linter
    evan-forbes committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    6e9cc65 View commit details
    Browse the repository at this point in the history
  11. commit to extended data instead of just the hash of the txs

    Basic DA functionality  (#83)
    
    * move Messages field to the end of Block.Data
    
    * Add some constants for share computation and the NMT:
    
     - also a bunch of todos regarding shares computation
    
    * First (compiling) stab on creating shares
    
    * Test with Evidence and fix bug discovered by test
    
    * remove resolved todos
    
    * introduce split method
    
    * Introduce LenDelimitedMarshaler interface and some reformatting
    
    * Introduce TxLenDelimitedMarshaler
    
    * add some test cases
    
    * fix some comments
    
    * fix some comments & linter
    
    * Add reserved namespaces to params
    
    * Move ll-specific consts into a separate file (consts.go)
    
    * Add MarshalDelimited to HexBytes
    
    * Add tail-padding shares
    
    * Add ComputeShares method on Data to compute all shares
    
    * Fix compute the next square num and not the next power of two
    
    * lints
    
    * Unexport MakeShares function:
    
    - it's likely to change and it doesn't have to be part of the public API
    
    * lints 2
    
    * First stab on computing row/column roots
    
    * fix rebase glitches:
     - move DA related constants out of params.go
    
    * refactor MakeBlock to take in interm. state roots and messages
    
    * refactor state.MakeBlock too
    
    * Add todos LenDelimitedMarshaler and extract appendShares logic
    
    * Simplify shares computation: remove LenDelimitedMarshaler abstraction
    
    * actually use DA header to compute the DataRoot everywhere (will lead to failing tests for sure)
    
    * WIP: Update block related core data structures in protobuf too
    
    * WIP: fix zero shares edge-case and get rid of Block.Data.hash (use dataAvailabilityHeader.Hash() instead)
    
    * Fixed tests, only 3 failing tests to go: TestReapMaxBytesMaxGas, TestTxFilter, TestMempoolFilters
    
    * Fix TestTxFilter:
    
     - the size of the wrapping Data{} proto message increased a few bytes
    
    * Fix Message proto and `DataFromProto`
    
    * Fix last 2 remaining tests related to the increased block/block.Data size
    
    * Use infectious lib instead of leopard
    
    * proto-lint: snake_case
    
    * some lints and minor changes
    
    * linter
    
    * panic if pushing to tree fails, extend Data.ToProto()
    
    * revert renaming in comment
    
    * add todo about refactoring as soon as the rsmt2d allows the user to choose the merkle tree
    
    clean up some unused test helper functions
    
    linter
    
    still debugging the exact right number of bytes for max data...
    evan-forbes committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    d9c4d6b View commit details
    Browse the repository at this point in the history
  12. abci: add preprocess block (#110)

    * version docs
    
    * stash commits
    
    * fix url
    
    * remove master from sidebar
    
    * fix build errors
    
    * move to consensus connection
    
    * add process
    
    * add proof to block
    
    * add block metadata in beginBlcok
    
    * fix testing
    
    * regenerate mocks
    
    * add in needed proto changes
    
    * regenerate mocks
    
    * fix makeblock calls
    
    * Apply suggestions from code review
    
    * fix rpc tests
    
    * fix linting and ci errors
    
    * fix consensus tests
    
    * add preprocess to e2e
    
    * add preprocess to counter app
    
    * replace meta_data with messages
    
    * fix linting
    
    * Update state/execution.go
    
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    
    * fix comment
    
    * fix e2e tests
    
    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    
    fix test so that it doesn't modify block data after generating the hash
    
    fix missed make block api change
    
    run make mockery
    
    add some docs
    
    fix hardcoded test
    
    fix linter
    
    fix hard coded test
    tac0turtle authored and evan-forbes committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    9133b9c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6cac512 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b3d5828 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6688073 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3d410e4 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e94c418 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5ccd668 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. build(deps): Bump github.com/go-kit/kit from 0.11.0 to 0.12.0 (#6988)

    Bumps [github.com/go-kit/kit](https://github.com/go-kit/kit) from 0.11.0 to 0.12.0.
    - [Release notes](https://github.com/go-kit/kit/releases)
    - [Commits](go-kit/kit@v0.11.0...v0.12.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/go-kit/kit
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Sep 24, 2021
    Configuration menu
    Copy the full SHA
    dd4141e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    363b87e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c909f8a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab8cfb9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b203c91 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e9ba48d View commit details
    Browse the repository at this point in the history
  7. e2e: skip validation of status apphash (#6991)

    I believe this assertion is likely redundant given that we're checking the block apphash.
    tychoish authored Sep 24, 2021
    Configuration menu
    Copy the full SHA
    08982c8 View commit details
    Browse the repository at this point in the history
  8. e2e: do not inject evidence through light proxy (#6992)

    In the last run, there were two problems at the RPC layer returned
    from light nodes' RPC end points. I think exercising the light client
    proxy RPC system is something that can/should be done via unit
    testing, and that likely these errors are (in production) transient
    and (in CI) very likely to fail for test environment issues.
    tychoish authored Sep 24, 2021
    Configuration menu
    Copy the full SHA
    5e45676 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dbad701 View commit details
    Browse the repository at this point in the history
  10. statesync: clean up reactor/syncer lifecylce (#6995)

    I've been noticing that there are a number of situations where the
    statesync reactor blocks waiting for peers (or similar,) I've moved
    things around to improve outcomes in local tests.
    tychoish authored Sep 24, 2021
    Configuration menu
    Copy the full SHA
    71c6682 View commit details
    Browse the repository at this point in the history
  11. abci: Flush socket requests and responses immediately. (#6997)

    The main effect of this change is to flush the socket client and server message
    encoding buffers immediately once the message is fully and correctly encoded.
    This allows us to remove the timer and some other special cases, without
    changing the observed behaviour of the system.
    
    -- Background
    
    The socket protocol client and server each use a buffered writer to encode
    request and response messages onto the underlying connection. This reduces the
    possibility of a single message being split across multiple writes, but has the
    side-effect that a request may remain buffered for some time.
    
    The implementation worked around this by keeping a ticker that occasionally
    triggers a flush, and by flushing the writer in response to an explicit request
    baked into the client/server protocol (see also #6994).
    
    These workarounds are both unnecessary: Once a message has been dequeued for
    sending and fully encoded in wire format, there is no real use keeping all or
    part of it buffered locally.  Moreover, using an asynchronous process to flush
    the buffer makes the round-trip performance of the request unpredictable.
    
    -- Benchmarks
    
    Code: https://play.golang.org/p/0ChUOxJOiHt
    
    I found no pre-existing performance benchmarks to justify the flush pattern,
    but a natural question is whether this will significantly harm client/server
    performance.  To test this, I implemented a simple benchmark that transfers
    randomly-sized byte buffers from a no-op "client" to a no-op "server" over a
    Unix-domain socket, using a buffered writer, both with and without explicit
    flushes after each write.
    
    As the following data show, flushing every time (FLUSH=true) does reduce raw
    throughput, but not by a significant amount except for very small request
    sizes, where the transfer time is already trivial (1.9μs).  Given that the
    client is calibrated for 1MiB transactions, the overhead is not meaningful.
    
    The percentage in each section is the speedup for flushing only when the buffer
    is full, relative to flushing every block.  The benchmark uses the default
    buffer size (4096 bytes), which is the same value used by the socket client and
    server implementation:
    
      FLUSH  NBLOCKS  MAX      AVG     TOTAL       ELAPSED       TIME/BLOCK
      false  3957471  512      255     1011165416  2.00018873s   505ns
      true   1068568  512      255     273064368   2.000217051s  1.871µs
                                                                 (73%)
    
      false  536096   4096     2048    1098066401  2.000229108s  3.731µs
      true   477911   4096     2047    978746731   2.000177825s  4.185µs
                                                                 (10.8%)
    
      false  124595   16384    8181    1019340160  2.000235086s  16.053µs
      true   120995   16384    8179    989703064   2.000329349s  16.532µs
                                                                 (2.9%)
    
      false  2114     1048576  525693  1111316541  2.000479928s  946.3µs
      true   2083     1048576  526379  1096449173  2.001817137s  961.025µs
                                                                 (1.5%)
    
    Note also that the FLUSH=false baseline is actually faster than the production
    code, which flushes more often than is required by the buffer filling up.
    
    Moreover, the timer slows down the overall transaction rate of the client and
    server, indepenedent of how fast the socket transfer is, so the loss on a real
    workload is probably much less.
    M. J. Fromberger authored Sep 24, 2021
    Configuration menu
    Copy the full SHA
    118bfe2 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. e2e: add limit and sort to generator (#6998)

    I observed a couple of problems with the generator in some recent tests: 
    
    - there were a couple of hybrid test cases which did not have any
      legacy nodes (randomness and all.) I change the probability to
      produce more reliable results.
    
    - added options to the generation to be able to add a max (to
      compliment the earlier min) number of nodes for local testing. 
    
    - added an option to support reversing the sort order so "more
      complex" networks were first, as well as tweaked some of the point
      values. 
    
    - this refactored the generators cli parsing to be a bit more clear.
    tychoish authored Sep 25, 2021
    Configuration menu
    Copy the full SHA
    c101fa1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37ca98a View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. e2e: improve chances of statesyncing success (#7001)

    This reduces this situation where a node will get stuck block syncing,
    which seemed to happen a lot in last nights run.
    tychoish authored Sep 26, 2021
    Configuration menu
    Copy the full SHA
    fb9eaf5 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Configuration menu
    Copy the full SHA
    60a6c6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bce7c2f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b879f71 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b150ea6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6eaa3b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8023a2a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a16d93 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6be3661 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Configuration menu
    Copy the full SHA
    1bd1593 View commit details
    Browse the repository at this point in the history
  2. e2e: use smaller transactions (#7016)

    75% of the failures in the last run all ran with the 10kb
    transactions. I'd like to dial it back and see if things improve more.
    tychoish authored Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e35a42f View commit details
    Browse the repository at this point in the history
  3. Update changelog for v0.35.0-rc2. (#7011)

    Also, relinkify and update the bounty URL.
    M. J. Fromberger authored Sep 28, 2021
    Configuration menu
    Copy the full SHA
    ea539dc View commit details
    Browse the repository at this point in the history
  4. e2e: skip validation of status apphash (#6991)

    I believe this assertion is likely redundant given that we're checking the block apphash.
    tychoish authored and evan-forbes committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    dfff228 View commit details
    Browse the repository at this point in the history
  5. e2e: do not inject evidence through light proxy (#6992)

    In the last run, there were two problems at the RPC layer returned
    from light nodes' RPC end points. I think exercising the light client
    proxy RPC system is something that can/should be done via unit
    testing, and that likely these errors are (in production) transient
    and (in CI) very likely to fail for test environment issues.
    tychoish authored and evan-forbes committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e33759b View commit details
    Browse the repository at this point in the history
  6. ci: use smart merges (#6993)

    tychoish authored and evan-forbes committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8878539 View commit details
    Browse the repository at this point in the history
  7. statesync: clean up reactor/syncer lifecylce (#6995)

    I've been noticing that there are a number of situations where the
    statesync reactor blocks waiting for peers (or similar,) I've moved
    things around to improve outcomes in local tests.
    tychoish authored and evan-forbes committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    0413dc8 View commit details
    Browse the repository at this point in the history
  8. abci: Flush socket requests and responses immediately. (#6997)

    The main effect of this change is to flush the socket client and server message
    encoding buffers immediately once the message is fully and correctly encoded.
    This allows us to remove the timer and some other special cases, without
    changing the observed behaviour of the system.
    
    -- Background
    
    The socket protocol client and server each use a buffered writer to encode
    request and response messages onto the underlying connection. This reduces the
    possibility of a single message being split across multiple writes, but has the
    side-effect that a request may remain buffered for some time.
    
    The implementation worked around this by keeping a ticker that occasionally
    triggers a flush, and by flushing the writer in response to an explicit request
    baked into the client/server protocol (see also #6994).
    
    These workarounds are both unnecessary: Once a message has been dequeued for
    sending and fully encoded in wire format, there is no real use keeping all or
    part of it buffered locally.  Moreover, using an asynchronous process to flush
    the buffer makes the round-trip performance of the request unpredictable.
    
    -- Benchmarks
    
    Code: https://play.golang.org/p/0ChUOxJOiHt
    
    I found no pre-existing performance benchmarks to justify the flush pattern,
    but a natural question is whether this will significantly harm client/server
    performance.  To test this, I implemented a simple benchmark that transfers
    randomly-sized byte buffers from a no-op "client" to a no-op "server" over a
    Unix-domain socket, using a buffered writer, both with and without explicit
    flushes after each write.
    
    As the following data show, flushing every time (FLUSH=true) does reduce raw
    throughput, but not by a significant amount except for very small request
    sizes, where the transfer time is already trivial (1.9μs).  Given that the
    client is calibrated for 1MiB transactions, the overhead is not meaningful.
    
    The percentage in each section is the speedup for flushing only when the buffer
    is full, relative to flushing every block.  The benchmark uses the default
    buffer size (4096 bytes), which is the same value used by the socket client and
    server implementation:
    
      FLUSH  NBLOCKS  MAX      AVG     TOTAL       ELAPSED       TIME/BLOCK
      false  3957471  512      255     1011165416  2.00018873s   505ns
      true   1068568  512      255     273064368   2.000217051s  1.871µs
                                                                 (73%)
    
      false  536096   4096     2048    1098066401  2.000229108s  3.731µs
      true   477911   4096     2047    978746731   2.000177825s  4.185µs
                                                                 (10.8%)
    
      false  124595   16384    8181    1019340160  2.000235086s  16.053µs
      true   120995   16384    8179    989703064   2.000329349s  16.532µs
                                                                 (2.9%)
    
      false  2114     1048576  525693  1111316541  2.000479928s  946.3µs
      true   2083     1048576  526379  1096449173  2.001817137s  961.025µs
                                                                 (1.5%)
    
    Note also that the FLUSH=false baseline is actually faster than the production
    code, which flushes more often than is required by the buffer filling up.
    
    Moreover, the timer slows down the overall transaction rate of the client and
    server, indepenedent of how fast the socket transfer is, so the loss on a real
    workload is probably much less.
    M. J. Fromberger authored and evan-forbes committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    cb172e1 View commit details
    Browse the repository at this point in the history
  9. e2e: add limit and sort to generator (#6998)

    I observed a couple of problems with the generator in some recent tests:
    
    - there were a couple of hybrid test cases which did not have any
      legacy nodes (randomness and all.) I change the probability to
      produce more reliable results.
    
    - added options to the generation to be able to add a max (to
      compliment the earlier min) number of nodes for local testing.
    
    - added an option to support reversing the sort order so "more
      complex" networks were first, as well as tweaked some of the point
      values.
    
    - this refactored the generators cli parsing to be a bit more clear.
    tychoish authored and evan-forbes committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    cb2eba5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2509d72 View commit details
    Browse the repository at this point in the history
  11. e2e: improve chances of statesyncing success (#7001)

    This reduces this situation where a node will get stuck block syncing,
    which seemed to happen a lot in last nights run.
    tychoish authored and evan-forbes committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c7041c9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    89a3167 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5efba6d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5866d13 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    be3f371 View commit details
    Browse the repository at this point in the history