Update codeowners to reflect fork #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
github_actions
liamsi
approved these changes
Sep 28, 2021
| @@ -18,7 +18,7 @@ jobs: | |||
| - name: Prepare | |||
| id: prep | |||
| run: | | |||
| DOCKER_IMAGE=tendermint/tendermint | |||
| DOCKER_IMAGE=celestiaorg/celestia-core | |||
There was a problem hiding this comment.
Do we actually push that image to somewhere?
There was a problem hiding this comment.
Nope for now afaik
A good finding for the issue #554 🧐
There was a problem hiding this comment.
we won't be pushing anything unless we create a docker hub account and attach it to the celestiaorg github account. Decided to change the docker image name instead of deleting the file, as that seemed useful
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to change the codeowners in #534, this PR changes that along with updating a few other minor things in the github actions directory
part of #528