Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump terser from 4.8.0 to 4.8.1 in /docs #801

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 21, 2022

Bumps terser from 4.8.0 to 4.8.1.

Changelog

Sourced from terser's changelog.

v4.8.1 (backport)

  • Security fix for RegExps that should not be evaluated (regexp DDOS)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added javascript Pull requests that update Javascript code T:dependencies Type: Pull requests that update a dependency file labels Jul 21, 2022
@adlerjohn
Copy link
Member

Hmmm why is this running when #794 was merged in? cc @evan-forbes. Is there another dependabot configuration or something?

@evan-forbes
Copy link
Member

Hmmm why is this running when #794 was merged in? cc @evan-forbes. Is there another dependabot configuration or something?

I'm not sure, I was hoping it had something to do with this being an npm dependency, but couldn't find anything

Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot changed the base branch from v0.35.x-celestia to v0.34.x-celestia August 3, 2022 01:33
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/docs/terser-4.8.1 branch from 58e815e to 0affc2b Compare August 3, 2022 01:33
@rootulp
Copy link
Collaborator

rootulp commented Aug 9, 2022

I also think dependabot shouldn't have opened this PR because NPM isn't configured.

Screenshot

Screen Shot 2022-08-09 at 3 55 01 PM

Based on these docs we can consider adding open-pull-requests-limit: 0 for npm. However, our current config should already have been sufficient: https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/.github/dependabot.yml

@rootulp
Copy link
Collaborator

rootulp commented Aug 9, 2022

@dependabot ignore this dependency

@dependabot dependabot bot closed this Aug 9, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 9, 2022

OK, I won't notify you about terser again, unless you re-open this PR or update it yourself. 😢

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/docs/terser-4.8.1 branch August 9, 2022 21:27
@rootulp
Copy link
Collaborator

rootulp commented Aug 9, 2022

For posterity, we actually do want this upgrade, however since this repo is a fork of tendermint/tendermint, we'll get this upgrade when we pull upstream changes that contain tendermint/tendermint#9051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code T:dependencies Type: Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants