Skip to content

Commit

Permalink
doc(share/p2p/shrexnd): Improve accuracy of RequestND description (#2418
Browse files Browse the repository at this point in the history
)

`RequestND` doesn't actually verify the inclusion proofs; this is done
later in `GetSharesByNamespace`:

https://github.com/celestiaorg/celestia-node/blob/main/share/getters/shrex.go#L237
  • Loading branch information
musalbas authored Jul 3, 2023
1 parent 44786bb commit 1a37094
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion share/p2p/shrexnd/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func NewClient(params *Parameters, host host.Host) (*Client, error) {
}

// RequestND requests namespaced data from the given peer.
// Returns valid data with its verified inclusion against the share.Root.
// Returns shares with unverified inclusion proofs against the share.Root.
func (c *Client) RequestND(
ctx context.Context,
root *share.Root,
Expand Down

0 comments on commit 1a37094

Please sign in to comment.