fix nits

blob/service.go

@@ -192,7 +192,7 @@ func (s *Service) GetAll(ctx context.Context, height uint64, namespaces []share.
 			blobs, err := s.getBlobs(ctx, namespace, header)
 			switch {
 			case err == nil:
-				log.Debugw("receiving blobs", "height", height, "total", len(blobs))
+				log.Infow("retrieved blobs", "height", height, "total", len(blobs))
 				resultBlobs[i] = blobs
 			case errors.Is(err, ErrBlobNotFound):
 			default:

blob/service_test.go

@@ -16,9 +16,11 @@ import (
 	tmrand "github.com/tendermint/tendermint/libs/rand"
 
 	"github.com/celestiaorg/celestia-app/pkg/appconsts"
+	appns "github.com/celestiaorg/celestia-app/pkg/namespace"
 	"github.com/celestiaorg/celestia-app/pkg/shares"
 	"github.com/celestiaorg/go-header/store"
 
+
 	"github.com/celestiaorg/celestia-node/blob/blobtest"
 	"github.com/celestiaorg/celestia-node/header"
 	"github.com/celestiaorg/celestia-node/header/headertest"
@@ -294,9 +296,9 @@ func TestBlobService_Get(t *testing.T) {
 			},
 		},
 		{
-			name: "empty result and err when blobs wer not found ",
+			name: "empty result and err when blobs were not found ",
 			doFn: func() (interface{}, error) {
-				nid, err := share.NewBlobNamespaceV0(tmrand.Bytes(7))
+				nid, err := share.NewBlobNamespaceV0(tmrand.Bytes(appns.NamespaceVersionZeroIDSize))
 				require.NoError(t, err)
 				return service.GetAll(ctx, 1, []share.Namespace{nid})
 			},
@@ -523,8 +525,9 @@ func TestAllPaddingSharesInEDS(t *testing.T) {
 	}
 
 	service := NewService(nil, getters.NewIPLDGetter(bs), fn)
-	_, err = service.GetAll(ctx, 1, []share.Namespace{nid})
-	require.Error(t, err)
+	newBlobs, err := service.GetAll(ctx, 1, []share.Namespace{nid})
+	require.NoError(t, err)
+	assert.Empty(t, newBlobs)
 }
 
 func TestSkipPaddingsAndRetrieveBlob(t *testing.T) {

nodebuilder/blob/blob.go

@@ -19,7 +19,15 @@ type Module interface {
 	Submit(_ context.Context, _ []*blob.Blob, _ blob.GasPrice) (height uint64, _ error)
 	// Get retrieves the blob by commitment under the given namespace and height.
 	Get(_ context.Context, height uint64, _ share.Namespace, _ blob.Commitment) (*blob.Blob, error)
-	// GetAll returns all blobs at the given height under the given namespaces.
+	// GetAll returns all blobs under the given namespaces at the given height.
+	// If all blobs were found without any errors, the user will receive a list of blobs.
+	// If the BlobService couldn't find any blobs under the requested namespaces,
+	// the user will receive an empty list of blobs along with an empty error.
+	// If some of the requested namespaces were not found, the user will receive all the found blobs and an empty error.
+	// If there were internal errors during some of the requests,
+	// the user will receive all found blobs along with a combined error message.
+	//
+	// All blobs will preserve the order of the namespaces that were requested.
 	GetAll(_ context.Context, height uint64, _ []share.Namespace) ([]*blob.Blob, error)
 	// GetProof retrieves proofs in the given namespaces at the given height by commitment.
 	GetProof(_ context.Context, height uint64, _ share.Namespace, _ blob.Commitment) (*blob.Proof, error)