Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrexnd: requesting data and/or proofs for multiple namespaces #1839

Closed
Tracked by #1835 ...
Wondertan opened this issue Feb 28, 2023 · 3 comments
Closed
Tracked by #1835 ...

shrexnd: requesting data and/or proofs for multiple namespaces #1839

Wondertan opened this issue Feb 28, 2023 · 3 comments
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Feb 28, 2023

Overview

The goal is to extend the protocol to enable requesting multiple data and/or data proofs in one request. The current state of the protocol allows fetching all the data within a certain namespace but not within multiple.

Motivation

This is solely a networking optimization for Get method of BlobModule which otherwise would require sending multiple concurrent requests instead of one. In response, this would allow sending fewer proofs if data from different namespaces happens to be on the same EDS row.

Details

The protobuf has to be updated to an array of namespaces instead of a single one. Subsequently, the response will need to be updated to reflect that and keep multiple namespaced data entries with proofs. Additionally, the subtask is to investigate NMT multi-proof API to avoid proof duplicates shared between different namespaces.

@Wondertan Wondertan added the area:shares Shares and samples label Feb 28, 2023
@renaynay renaynay changed the title shrend: requesting data and/or proofs for multiple namespaces shrexnd: requesting data and/or proofs for multiple namespaces Mar 2, 2023
@distractedm1nd
Copy link
Collaborator

Is this really necessary?

@Wondertan
Copy link
Member Author

Wondertan commented Sep 24, 2023

I see value in this optimisation long-term. Especially since Rollups want to use multiple namespaces or their block, e.g. one for headers and one for blocks. Anyway, does not hurt to keep an issue

@vgonkivs
Copy link
Member

Close until we will need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples
Projects
No open projects
Status: TODO
Development

No branches or pull requests

4 participants