Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitoring): define custom buckets per histogram #2470

Open
walldiss opened this issue Jul 13, 2023 · 1 comment
Open

feat(monitoring): define custom buckets per histogram #2470

walldiss opened this issue Jul 13, 2023 · 1 comment
Assignees
Labels
area:metrics Related to measuring/collecting node metrics enhancement New feature or request

Comments

@walldiss
Copy link
Member

Implementation ideas

All histogram metrics currently are using same predefined buckets values, that makes most of them unusable due to buckets being disproportional to observed values. With current version of otel it is only possible to set buckets values on global meter, but given different nature of each histogram it makes it unusable.

This is known issue of otel and tracked in:
open-telemetry/opentelemetry-go#3826.
API spec improvement has been suggested and merged in:
open-telemetry/opentelemetry-specification#3216
Implimentation is still to be done. And tracked in:
open-telemetry/opentelemetry-go#4094

Once support of bucket boundary metric advice support is implemented in otel we need to add custom bucket per each histogram.

@walldiss walldiss added enhancement New feature or request area:metrics Related to measuring/collecting node metrics labels Jul 13, 2023
@walldiss
Copy link
Member Author

Since otel bump in #3068 custom buckets are now possible. We need to revise our histogram definitions and set up sensible buckets values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Related to measuring/collecting node metrics enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants