Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental histogram advice API #4094

Closed
MrAlias opened this issue May 17, 2023 · 7 comments · Fixed by #4605
Closed

Add experimental histogram advice API #4094

MrAlias opened this issue May 17, 2023 · 7 comments · Fixed by #4605
Assignees
@dashpole
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:API Related to an API package
Milestone
v1.20.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented May 17, 2023

Specification PR: open-telemetry/opentelemetry-specification#3216
@MrAlias MrAlias added enhancement New feature or request pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics labels May 17, 2023
@walldiss walldiss mentioned this issue Jul 13, 2023
Open
@codeboten
Copy link
Contributor

I believe this would solve #3826

@codeboten codeboten mentioned this issue Sep 19, 2023
Closed
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 19, 2023

Prototype: #4341

@dashpole
Copy link
Contributor

@MrAlias @MadVikingGod Should we include this in the next (GA) release now that the specification is stable? It seems like one of the most requested features from users, and would be great to have if there are no objections.

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 20, 2023 •
edited
Loading

@MrAlias @MadVikingGod Should we include this in the next (GA) release now that the specification is stable? It seems like one of the most requested features from users, and would be great to have if there are no objections.

I think adding it in v1.20.0 sounds good to me. The RC for 1.19.0 has already been released. Adding this to the API in that release would mean the SDK needs to be updated to support it. Given that is a major change worth a minor version release I don't think we can add it to an RC. But I do think the next minor release should be targeted for this 👍 .

@MrAlias MrAlias added this to the v1.20.0 milestone Sep 20, 2023
@dashpole
Copy link
Contributor

We can start working on this now, right? Or do we need to wait until the after the SDK has been released?

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 21, 2023

We can start working on this now, right? Or do we need to wait until the after the SDK has been released?

As long as we don't merge something to main until we make the next release, that sounds good to me. 👍

@dashpole
Copy link
Contributor

I'll just wait in that case

@dashpole dashpole self-assigned this Oct 10, 2023
This was referenced Oct 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:API Related to an API package
Projects
Go: Metric API (Post-GA)
Status: Done
Milestone
v1.20.0
Development

Successfully merging a pull request may close this issue.

Implement WithExplicitBucketBoundaries option in the metric SDK dashpole/opentelemetry-go
3 participants
@codeboten @dashpole @MrAlias