Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for secondary reserved namespace range #2561

Closed
rootulp opened this issue Aug 12, 2023 · 2 comments · Fixed by #2597
Closed

Account for secondary reserved namespace range #2561

rootulp opened this issue Aug 12, 2023 · 2 comments · Fixed by #2597
Assignees
@rootulp
Labels
area:core_and_app Relationship with Core node and Celestia-App external Issues created by non node team members needs:triage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Aug 12, 2023 •
edited
Loading

Context

celestia-app is considering making a breaking change to reserve the last 256 namespaces (see celestiaorg/celestia-app#2253). Relevant PR celestiaorg/celestia-app#2257

Problem

If celestiaorg/celestia-app#2257 merges, we need to update celestia-node's namespace to account for the change.

Proposal

  1. Rename MaxReservedNamespace to MaxPrimaryReservedNamespace
  2. Rename ReservedPaddingNamespace to PrimaryReservedPaddingNamespace
  3. Add MinSecondaryReservedNamespace constant to this list
  4. ValidateForBlob should account for the secondary reserved namespace range.
  5. Add unit tests

Originally posted by @rootulp in celestiaorg/celestia-app#2257 (comment)
@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Aug 12, 2023
@rootulp rootulp changed the title > Does node needs to be updated with this? Account for secondary reserved namespace range Aug 12, 2023
@rootulp rootulp added the area:core_and_app Relationship with Core node and Celestia-App label Aug 12, 2023
@rootulp rootulp self-assigned this Aug 12, 2023
@rootulp rootulp mentioned this issue Aug 12, 2023
Closed
This was referenced Aug 21, 2023
Merged
Merged
@renaynay
Copy link
Member

@rootulp is this mostly resolved?

@Wondertan
Copy link
Member

@renaynay, just needs #2597 to be merged

rootulp added a commit that referenced this issue Aug 24, 2023
@rootulp
refactor: address namespace follow-ups from celestia-app v1.0.0-rc12 …
1205437 
…bump (#2597)

Addresses two follow-ups from
#2581
Closes #2561
walldiss pushed a commit to walldiss/celestia-node that referenced this issue Sep 22, 2023
@rootulp @walldiss
refactor: address namespace follow-ups from celestia-app v1.0.0-rc12 …
c6ee275 
…bump (celestiaorg#2597)

Addresses two follow-ups from
celestiaorg#2581
Closes celestiaorg#2561

(cherry picked from commit 1205437)
walldiss pushed a commit that referenced this issue Sep 22, 2023
@rootulp @walldiss
refactor: address namespace follow-ups from celestia-app v1.0.0-rc12 …
1834813 
…bump (#2597)

Addresses two follow-ups from
#2581
Closes #2561

(cherry picked from commit 1205437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
area:core_and_app Relationship with Core node and Celestia-App external Issues created by non node team members needs:triage
Projects
None yet
Milestone
No milestone
3 participants
@rootulp @Wondertan @renaynay