Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipld: Consolidation with share #878

Closed
Tracked by #1099
Wondertan opened this issue Jul 3, 2022 · 0 comments · Fixed by #1177
Closed
Tracked by #1099

ipld: Consolidation with share #878

Wondertan opened this issue Jul 3, 2022 · 0 comments · Fixed by #1177
Assignees
@walldiss
Labels
area:ipld IPLD plugin

Comments

@Wondertan
Copy link
Member

Wondertan commented Jul 3, 2022 •
edited
Loading

Proposed pkg restuctures:

  • Extract share out of service: service/share -> share
    • Same as we did with header and fraud
  • Move content of ipld to the new share.
    • The code there is really about fetching/retrieving shares and not about defining ipld thing, while only the current ipld/plugin is (1)
  • Move content of ipld/plugin to the new share/ipld
@Wondertan Wondertan added the area:ipld IPLD plugin label Jul 3, 2022
@Bidon15 Bidon15 mentioned this issue Jul 12, 2022
Closed
5 tasks
@renaynay renaynay mentioned this issue Jul 28, 2022
Closed
30 tasks
This was referenced Sep 15, 2022
Closed
Closed
@Wondertan Wondertan changed the title ipld: Consider consolidation with share ipld: Consolidation with share Sep 16, 2022
This was referenced Sep 16, 2022
Closed
Closed
@Wondertan Wondertan assigned walldiss and unassigned Wondertan Sep 20, 2022
@walldiss walldiss mentioned this issue Sep 30, 2022
Merged
walldiss added a commit that referenced this issue Oct 12, 2022
@walldiss @renaynay
refactor(share): Consolidate share pkg (#1177)
793e2b0 
Resolves #878

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
tzdybal pushed a commit to celestiaorg/go-header that referenced this issue Dec 7, 2022
@walldiss @renaynay
refactor(share): Consolidate share pkg (#1177)
b466bd3 
Resolves celestiaorg/celestia-node#878

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Wondertan pushed a commit to celestiaorg/go-fraud that referenced this issue Apr 12, 2023
@walldiss @renaynay @Wondertan
refactor(share): Consolidate share pkg (#1177)
22b12e9 
Resolves celestiaorg/celestia-node#878

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walldiss walldiss

Labels
area:ipld IPLD plugin
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(share): Consolidate share pkg walldiss/celestia-node
2 participants
@walldiss @Wondertan