-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(header): Check app version in eh validation and return err on mismatch #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:core_and_app
Relationship with Core node and Celestia-App
kind:feat
Attached to feature PRs
labels
Apr 27, 2023
renaynay
force-pushed
the
app-check
branch
2 times, most recently
from
June 2, 2023 14:59
b354158
to
8bd61c7
Compare
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
June 15, 2023 14:26
cmwaters
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this works for now
Wondertan
previously approved these changes
Jun 15, 2023
distractedm1nd
previously approved these changes
Jun 16, 2023
Wait a sec
|
will investigate |
waiting on @cmwaters to update testnode in core to set app version |
distractedm1nd
approved these changes
Jun 16, 2023
Wondertan
approved these changes
Jun 16, 2023
It's also a dep update PR |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jun 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by @cmwaters, we should ensure (as a rudimentary check) that the headers being passed to us from core match in app versions as upgraded app versions can indicate breaking changes.
We should error out if the app version does not match.
This PR is still draft until celestia-app has a version out where they export the AppVersion as a const that we can depend on.
Eventually we should support several versions via #2137 but for now, this is a good enough check.
TODO: