feat!: bump app v1.0.0-rc0 #2253

evan-forbes · 2023-05-25T00:01:39Z

Overview

bumps app to v1.0.0-rc0

Checklist

New and updated code has appropriate documentation
New and updated code has new and/or updated testing
Required CI checks are passing
Visual proof for any user facing features like CLI or documentation updates
Linked issues closed with keywords

by regenerating testdata b/c roots are longer

remove test b/c it seems duplicative of TestService_GetSharesByNamespaceNotFound

api/gateway/share_test.go

core/eds_test.go

go.mod

share/availability/light/availability_test.go

share/eds/eds_test.go

evan-forbes · 2023-05-25T00:17:36Z

all tests are passing locally for me, can others pls double check?

core/eds.go

core/eds_test.go

share/availability/light/availability_test.go

share/eds/eds_test.go

api/gateway/share_test.go

core/eds_test.go

Co-authored-by: Rootul P <rootulp@gmail.com>

go.mod

api/gateway/share_test.go

core/eds_test.go

core/eds.go

share/eds/eds.go

share/eds/eds_test.go

api/gateway/share_test.go

Wondertan

Thank you @rootulp and @evan-forbes

rootulp added 30 commits March 31, 2023 16:00

chore!: bump to celestia-app v0.14.0-rc0

3295453

fix tests

a135598

wip: mark tests that need fixing

769f48e

wip: debug TestService_GetSharesByNamespace

647c90e

celestia-node depends on ignoreMaxNs

3382a47

chore: remove 8 from sha256Namespace8Flagged

2af019a

fix: TestService_GetSharesByNamespace

56f2ff5

feat: verifyAny row root

4a4be1c

revert: getter.go b/c modifying celestia-app parity namespace

c0cfc7f

revert: unnecessary changes b/c parity namespace id in celestia-app

f515546

fix TestSharesRoundTrip

e81ed85

fix: TestQuadrantOrder

62ab0d4

fix: TestReadEDS

4460faa

by regenerating testdata b/c roots are longer

Merge branch 'main' into rp/bump-celestia-app

0e988cf

chore: prefer crypto/rand over math/rand

551b0da

chore: upgrade to celestia-app v0.14.0-rc2

f3b5d9f

Merge branch 'main' into rp/bump-celestia-app

d9a573c

fix comment

0a9c80c

fix: lint

f934f9e

Merge branch 'main' into rp/bump-celestia-app

24d253e

fix: TestShrexGetter

23a611d

fix: GetSharesByNamespace

0b37134

fix: TestExchange_RequestND_NotFound

d3a6243

fix: TestStoreGetter

2e1e5ce

fix: TestService_GetSharesByNamespace

9cee800

remove test b/c it seems duplicative of TestService_GetSharesByNamespaceNotFound

fix: TestRetriever_ByzantineError

c505103

chore: address @Wondertan feedback

df4d5f1

Merge branch 'main' into rp/bump-celestia-app

18117b7

Merge branch 'main' into rp/bump-celestia-app

ed41784

chore: upgrade to celestia-app v0.15.0-rc0

4f3e0ee

evan-forbes commented May 25, 2023

View reviewed changes

api/gateway/share_test.go Outdated Show resolved Hide resolved

core/eds_test.go Outdated Show resolved Hide resolved

go.mod Show resolved Hide resolved

share/availability/light/availability_test.go Show resolved Hide resolved

share/eds/eds_test.go Show resolved Hide resolved

evan-forbes added 4 commits May 24, 2023 19:18

fix: linter

727f946

chore: bump tag

3d9d777

fix: linter

a52164f

chore: cleanup

74da567

renaynay reviewed May 25, 2023

View reviewed changes

core/eds.go Show resolved Hide resolved

core/eds_test.go Show resolved Hide resolved

share/availability/light/availability_test.go Show resolved Hide resolved

share/availability/light/availability_test.go Show resolved Hide resolved

share/eds/eds_test.go Outdated Show resolved Hide resolved

evan-forbes mentioned this pull request May 25, 2023

Create a helper function that generates an EDS directly from block data celestiaorg/celestia-app#1830

Closed

evan-forbes added 2 commits May 25, 2023 09:22

chore: remove unnecessary append

7c17cbc

chore: remove unused testdata

01bbd0d

rootulp previously approved these changes May 25, 2023

View reviewed changes

api/gateway/share_test.go Outdated Show resolved Hide resolved

core/eds_test.go Outdated Show resolved Hide resolved

core/eds_test.go Outdated Show resolved Hide resolved

chore: use local fields

256f34b

Co-authored-by: Rootul P <rootulp@gmail.com>

evan-forbes dismissed rootulp’s stale review via 256f34b May 25, 2023 21:08

evan-forbes and others added 3 commits May 25, 2023 16:09

chore: typo

0d841f6

Co-authored-by: Rootul P <rootulp@gmail.com>

chore: docs

1678099

Co-authored-by: Rootul P <rootulp@gmail.com>

Merge branch 'main' into evan/bump-app-v1

385c3f3

Wondertan reviewed May 26, 2023

View reviewed changes

Wondertan added 2 commits May 29, 2023 10:46

fix review comments

b57e78e

Merge branch 'main' into evan/bump-app-v1

21ca1db

Wondertan reviewed May 29, 2023

View reviewed changes

api/gateway/share_test.go Show resolved Hide resolved

Wondertan mentioned this pull request May 29, 2023

core: move empty square tests to share/empty_test.go #2266

Open

Wondertan approved these changes May 29, 2023

View reviewed changes

Wondertan enabled auto-merge (squash) May 29, 2023 09:09

vgonkivs approved these changes May 29, 2023

View reviewed changes

renaynay approved these changes May 29, 2023

View reviewed changes

distractedm1nd approved these changes May 29, 2023

View reviewed changes

Wondertan merged commit 9359b65 into celestiaorg:main May 29, 2023

adlerjohn mentioned this pull request Jun 28, 2023

Update notify to v0.9.3 to fix deprecation warning on MacOS 13. #2222

Closed

5 tasks

faddat mentioned this pull request Feb 22, 2024

feat: go 1.22 and pebble v1.1.0 for celestia-node #3202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: bump app v1.0.0-rc0 #2253

feat!: bump app v1.0.0-rc0 #2253

evan-forbes commented May 25, 2023 •

edited

Loading

evan-forbes commented May 25, 2023

Wondertan left a comment

feat!: bump app v1.0.0-rc0 #2253

feat!: bump app v1.0.0-rc0 #2253

Conversation

evan-forbes commented May 25, 2023 • edited Loading

Overview

Checklist

evan-forbes commented May 25, 2023

Wondertan left a comment

Choose a reason for hiding this comment

evan-forbes commented May 25, 2023 •

edited

Loading