Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blob): register on the client and doc gen #2272

Merged

Conversation

vgonkivs
Copy link
Member

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added kind:feat Attached to feature PRs area:blob labels May 30, 2023
@vgonkivs vgonkivs requested a review from jcstein May 30, 2023 08:03
@vgonkivs vgonkivs self-assigned this May 30, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature_branch_blob_module@3f4a7cf). Click here to learn what that means.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##             feature_branch_blob_module    #2272   +/-   ##
=============================================================
  Coverage                              ?   50.58%           
=============================================================
  Files                                 ?      154           
  Lines                                 ?     9643           
  Branches                              ?        0           
=============================================================
  Hits                                  ?     4878           
  Misses                                ?     4341           
  Partials                              ?      424           

@vgonkivs vgonkivs changed the title feat(blob/doc): add blob module documentation feat(blob/doc): add blob module documentation and register blob ppc May 30, 2023
@vgonkivs vgonkivs changed the title feat(blob/doc): add blob module documentation and register blob ppc feat(blob/doc): add blob module documentation and register blob rpc May 30, 2023
@Wondertan Wondertan changed the title feat(blob/doc): add blob module documentation and register blob rpc feat(blob): register on the client and doc gen May 30, 2023
@distractedm1nd
Copy link
Collaborator

Once we merge into main we need to remember to update the openrpc.json spec in this branch https://github.com/celestiaorg/celestia-node/tree/openrpc-spec so that our frontend will update. Also have to prepare some docs updates with @jcstein before we upgrade a network with it

@vgonkivs vgonkivs merged commit 285ae30 into celestiaorg:feature_branch_blob_module May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants