-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nodebuilder): add ip resolving capabilities to core.ip #2277
feat(nodebuilder): add ip resolving capabilities to core.ip #2277
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 50.65% 50.57% -0.09%
==========================================
Files 154 154
Lines 9620 9620
==========================================
- Hits 4873 4865 -8
- Misses 4323 4330 +7
- Partials 424 425 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document on the command that we can now resolve DNSs and mention that the first one resolved is always used and then LGTM
Done and updated the PR |
Thank you @sysrex! |
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Overview
Checklist