Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: local docker telemetry infra #2296

Merged
merged 10 commits into from
Sep 4, 2023
Merged

Conversation

distractedm1nd
Copy link
Collaborator

Supersedes #1990

Adds local telemetry infra to the Makefile. This includes pyroscope, grafana, jaeger, an otel-collector, prometheus, and loki.

@distractedm1nd distractedm1nd added area:repository Issues related to Node's or Core's repository kind:feat Attached to feature PRs labels Jun 1, 2023
@distractedm1nd distractedm1nd self-assigned this Jun 1, 2023
renaynay
renaynay previously approved these changes Jun 16, 2023
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this just yamllint

@Wondertan
Copy link
Member

@musalbas

Copy link
Contributor

@derrandz derrandz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see this finally coming useful

renaynay
renaynay previously approved these changes Sep 4, 2023
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go

@distractedm1nd distractedm1nd enabled auto-merge (squash) September 4, 2023 12:44
@codecov-commenter
Copy link

Codecov Report

Merging #2296 (9decec7) into main (d75a743) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
+ Coverage   51.09%   51.14%   +0.04%     
==========================================
  Files         158      158              
  Lines       10558    10558              
==========================================
+ Hits         5395     5400       +5     
+ Misses       4688     4682       -6     
- Partials      475      476       +1     

see 5 files with indirect coverage changes

@distractedm1nd distractedm1nd merged commit a31a808 into main Sep 4, 2023
16 of 18 checks passed
@distractedm1nd distractedm1nd deleted the local-telemetry-infra branch September 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:repository Issues related to Node's or Core's repository kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants