Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swamp): use synchronized map as container for nodes #2358

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

Wondertan
Copy link
Member

While fixing #825, I discovered a race. We were not synchronizing writes to containers on the node. Additionally, I simplified storing of registered nodes by using map instead of per type slices. We don't use this per type separation anyhow

@Wondertan Wondertan added swamp Related to Integration tests kind:fix Attached to bug-fixing PRs labels Jun 12, 2023
@Wondertan Wondertan requested a review from renaynay as a code owner June 12, 2023 19:56
@Wondertan Wondertan self-assigned this Jun 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2358 (7e48e12) into main (0823f6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2358   +/-   ##
=======================================
  Coverage   50.86%   50.86%           
=======================================
  Files         154      154           
  Lines        9742     9742           
=======================================
  Hits         4955     4955           
  Misses       4353     4353           
  Partials      434      434           

see 2 files with indirect coverage changes

distractedm1nd
distractedm1nd previously approved these changes Jun 13, 2023
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, looks good and makes sense

@Wondertan Wondertan merged commit d0e4353 into main Jun 14, 2023
@Wondertan Wondertan deleted the hlib/fix-race-reconstruction branch June 14, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs swamp Related to Integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants