-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share/byzantine): handle additional cases in befp validation #2383
Conversation
40965ec
to
b7a7ca0
Compare
Codecov Report
@@ Coverage Diff @@
## main #2383 +/- ##
==========================================
+ Coverage 50.44% 50.64% +0.20%
==========================================
Files 155 156 +1
Lines 9826 9876 +50
==========================================
+ Hits 4957 5002 +45
+ Misses 4433 4432 -1
- Partials 436 442 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I just realized that this is only the verification part. We have to triple-check that the generation works for these cases.
These cases are possible with out-of-order shares. But we can't generate them for now |
Moving this PR to draft until we can test these conditions |
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
b079ea0
to
78f67d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one non-non-blocking comment
Overview
Extend a BEFP validation.
Related to #2377
Checklist