-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(libs/utils): Use valid ip4 address #2394
Merged
Wondertan
merged 4 commits into
celestiaorg:main
from
renaynay:allow-localhost-addrparse
Jun 27, 2023
Merged
fix(libs/utils): Use valid ip4 address #2394
Wondertan
merged 4 commits into
celestiaorg:main
from
renaynay:allow-localhost-addrparse
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
June 23, 2023 15:09
We have tests for the func and should cover this case |
Codecov Report
@@ Coverage Diff @@
## main #2394 +/- ##
==========================================
- Coverage 50.74% 50.52% -0.22%
==========================================
Files 157 157
Lines 9925 9925
==========================================
- Hits 5036 5015 -21
- Misses 4445 4464 +19
- Partials 444 446 +2
|
Why do you think the address is invalid? |
@walldiss first addr returned for localhost is ipv6 shorthand loopback addr and it's not compatible with validation |
To filter out ipv6 you can use
|
Wondertan
previously approved these changes
Jun 27, 2023
renaynay
changed the title
fix(libs/utils): Use valid address from LookupHost addr slice
fix(libs/utils): Use valid ip4 address
Jun 27, 2023
walldiss
reviewed
Jun 27, 2023
walldiss
approved these changes
Jun 27, 2023
Wondertan
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
localhost
was not accepted as a valid--gateway.addr
. Uses net.ResolveIPAddr instead.Found by @tuxcanfly