feat: update Go base alpine - add branch in makefile #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
tty47
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
tty47
added
docker
Codecov Report
@@ Coverage Diff @@
## main #2414 +/- ##
=======================================
Coverage 53.05% 53.05%
=======================================
Files 156 156
Lines 9915 9915
=======================================
Hits 5260 5260
- Misses 4199 4200 +1
+ Partials 456 455 -1 |
Bidon15
approved these changes
Jun 30, 2023
renaynay
approved these changes
Jun 30, 2023
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Jul 4, 2023
hello team! This PR contains a couple of things: - Update the base version of Go Alpine to `golang:1.20-alpine3.18` - In the Makefile, I've added the following line: ```Makefile main.semanticVersion=$(shell git describe --tags --dirty=-dev 2>/dev/null || git rev-parse --abbrev-ref HEAD)'" ``` Basically what it does is, in case this commit doesn't contain any tag, it uses the branch name. At the moment we are having some issues using the flag `version`, the output command is:  With this change, we'll have something like:  *Already tested* Let me know what you think about it and if it's worth it 😊 Thanks in advance! 🚀 Jose Ramon Mañes --------- Signed-off-by: Jose Ramon Mañes <jose@celestia.org> Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello team!
This PR contains a couple of things:
golang:1.20-alpine3.18Basically what it does is, in case this commit doesn't contain any tag, it uses the branch name.
At the moment we are having some issues using the flag
version, the output command is:With this change, we'll have something like:
Already tested
Let me know what you think about it and if it's worth it 😊
Thanks in advance! 🚀
Jose Ramon Mañes