Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump celestia app v1.0.0-rc9 #2458

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jul 11, 2023

Overview

this PR bumps app, core, the sdk, and rsmt2d

besides the update to rsmt2d, the only app/core related changes are to the timeout commit. We're reverting to what was used for previous testnets (such as BSR), where we have a static timeout after reaching 2/3s in the commit instead of a dynamic one.

closes #2448

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes marked this pull request as draft July 11, 2023 22:02
@evan-forbes evan-forbes self-assigned this Jul 11, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Jul 11, 2023
@evan-forbes evan-forbes added kind:deps Pull requests that update a dependency file and removed external Issues created by non node team members labels Jul 11, 2023
@evan-forbes
Copy link
Member Author

leaving as a draft until the official tag comes out

also TestDASer_stopsAfter_BEFP is failing which I think makes sense since we've updated rsmt2d, but I'm not entirely sure what's the best way to fix it.

share/eds/retriever.go Outdated Show resolved Hide resolved
@evan-forbes
Copy link
Member Author

anyone should feel free to push to this PR to fix or update things as I might be gone cc @rootulp @Wondertan

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
share/eds/retriever.go Outdated Show resolved Hide resolved
rootulp
rootulp previously approved these changes Jul 12, 2023
nodebuilder/tests/swamp/config.go Outdated Show resolved Hide resolved
share/eds/eds.go Show resolved Hide resolved
share/eds/eds_test.go Outdated Show resolved Hide resolved
@Wondertan Wondertan marked this pull request as ready for review July 12, 2023 15:45
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and needs one more review from the node team member

@codecov-commenter
Copy link

Codecov Report

Merging #2458 (be28920) into main (c8fa853) will decrease coverage by 0.13%.
The diff coverage is 36.00%.

@@            Coverage Diff             @@
##             main    #2458      +/-   ##
==========================================
- Coverage   53.05%   52.93%   -0.13%     
==========================================
  Files         156      156              
  Lines        9940     9964      +24     
==========================================
  Hits         5274     5274              
- Misses       4210     4227      +17     
- Partials      456      463       +7     
Impacted Files Coverage Δ
header/headertest/testing.go 71.92% <0.00%> (-0.56%) ⬇️
share/empty.go 0.00% <0.00%> (ø)
share/ipld/add.go 28.57% <12.50%> (-4.77%) ⬇️
share/eds/eds.go 63.72% <36.84%> (-3.65%) ⬇️
nodebuilder/share/constructors.go 10.20% <40.00%> (-2.57%) ⬇️
share/getters/testing.go 83.33% <50.00%> (-8.98%) ⬇️
share/eds/retriever.go 85.63% <100.00%> (+0.23%) ⬆️

... and 7 files with indirect coverage changes

@Wondertan Wondertan merged commit 7fe4fee into main Jul 12, 2023
15 of 17 checks passed
@Wondertan Wondertan deleted the evan/bump-celestia-app-v1.0.0-rc9 branch July 12, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump rsmt2d to 0.10.0
6 participants