Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(share/p2p/discovery): demote disc peers log to debug #2473

Merged
merged 3 commits into from
Jul 13, 2023
Merged

chore(share/p2p/discovery): demote disc peers log to debug #2473

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1537384
chore(share/p2p/discovery): demote disc peers log to debug
renaynay Jul 13, 2023
4f5b85a
Merge branch 'main' into debug-log
Wondertan Jul 13, 2023
de7cddf
Merge branch 'main' into debug-log
walldiss Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion share/p2p/discovery/discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,10 @@ func (d *Discovery) discover(ctx context.Context) bool {
log.Debugw("reached soft peer limit, skipping discovery", "size", size)
return true
}
log.Infow("discovering peers", "want", want)
// TODO @renaynay: eventually, have a mechanism to catch if wanted amount of peers
renaynay marked this conversation as resolved.
Show resolved Hide resolved
// has not been discovered in X amount of time so that users are warned of degraded
// FN connectivity.
log.Debugw("discovering peers", "want", want)

// we use errgroup as it provide limits
var wg errgroup.Group
Expand Down