-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(share/availability): don't log error canceled operation #2475
Merged
renaynay
merged 4 commits into
celestiaorg:main
from
walldiss:update_availability_error_log
Jul 14, 2023
Merged
refactor(share/availability): don't log error canceled operation #2475
renaynay
merged 4 commits into
celestiaorg:main
from
walldiss:update_availability_error_log
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
area:shares
Shares and samples
kind:refactor
Attached to refactoring PRs
labels
Jul 14, 2023
walldiss
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
July 14, 2023 05:40
walldiss
changed the title
refactor(share/availability): don't log errors on shutdown
refactor(share/availability): don't log errors caused by shutdown
Jul 14, 2023
walldiss
changed the title
refactor(share/availability): don't log errors caused by shutdown
refactor(share/availability): don't log errors if operation is canceled
Jul 14, 2023
walldiss
changed the title
refactor(share/availability): don't log errors if operation is canceled
refactor(share/availability): don't log error canceled operation
Jul 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #2475 +/- ##
==========================================
+ Coverage 52.88% 53.05% +0.16%
==========================================
Files 156 156
Lines 9971 9973 +2
==========================================
+ Hits 5273 5291 +18
+ Misses 4236 4221 -15
+ Partials 462 461 -1
|
Wondertan
reviewed
Jul 14, 2023
Wondertan
previously approved these changes
Jul 14, 2023
renaynay
reviewed
Jul 14, 2023
Wondertan
approved these changes
Jul 14, 2023
renaynay
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup to prevent node from spamming error availability logs on shutdown.