Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(share/availability): don't log error canceled operation #2475

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

walldiss
Copy link
Member

Small cleanup to prevent node from spamming error availability logs on shutdown.

@walldiss walldiss added area:shares Shares and samples kind:refactor Attached to refactoring PRs labels Jul 14, 2023
@walldiss walldiss requested a review from renaynay as a code owner July 14, 2023 05:40
@walldiss walldiss self-assigned this Jul 14, 2023
@walldiss walldiss changed the title refactor(share/availability): don't log errors on shutdown refactor(share/availability): don't log errors caused by shutdown Jul 14, 2023
@walldiss walldiss changed the title refactor(share/availability): don't log errors caused by shutdown refactor(share/availability): don't log errors if operation is canceled Jul 14, 2023
@walldiss walldiss changed the title refactor(share/availability): don't log errors if operation is canceled refactor(share/availability): don't log error canceled operation Jul 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2475 (cf1fe32) into main (11dced4) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
+ Coverage   52.88%   53.05%   +0.16%     
==========================================
  Files         156      156              
  Lines        9971     9973       +2     
==========================================
+ Hits         5273     5291      +18     
+ Misses       4236     4221      -15     
+ Partials      462      461       -1     
Impacted Files Coverage Δ
share/availability/full/availability.go 48.71% <100.00%> (+2.77%) ⬆️

... and 4 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes Jul 14, 2023
@renaynay renaynay enabled auto-merge (squash) July 14, 2023 15:33
@renaynay renaynay merged commit b59c21c into celestiaorg:main Jul 14, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants