Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traces): rework trace creation #2476

Closed
wants to merge 6 commits into from

Conversation

vgonkivs
Copy link
Member

Overview

Depends on #2468

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added kind:feat Attached to feature PRs area:metrics Related to measuring/collecting node metrics labels Jul 14, 2023
@vgonkivs vgonkivs self-assigned this Jul 14, 2023
@vgonkivs vgonkivs changed the title Rework trace creation feat(traces): rework trace creation Jul 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2476 (cf206c1) into main (11dced4) will decrease coverage by 0.34%.
The diff coverage is 4.87%.

@@            Coverage Diff             @@
##             main    #2476      +/-   ##
==========================================
- Coverage   52.88%   52.55%   -0.34%     
==========================================
  Files         156      156              
  Lines        9971     9998      +27     
==========================================
- Hits         5273     5254      -19     
- Misses       4236     4279      +43     
- Partials      462      465       +3     
Impacted Files Coverage Δ
cmd/celestia/util.go 56.52% <ø> (-5.02%) ⬇️
cmd/celestia/version.go 0.00% <0.00%> (ø)
nodebuilder/settings.go 45.68% <5.71%> (-18.60%) ⬇️

... and 7 files with indirect coverage changes

@vgonkivs vgonkivs closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Related to measuring/collecting node metrics kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants