Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edssser): introduce EDS Store Stresser and cel-shed utility #2482

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Jul 15, 2023

We need a way to stress test EDS Store now and long-term. This PR provides a tool that can be used to run such tests and measure, debug, explore, and fine-tune various aspects of the EDS storing sub-system in isolation.

The main goal is to investigate #2480 and ensure the future fix/solution is

@Wondertan Wondertan added the kind:feat Attached to feature PRs label Jul 15, 2023
@Wondertan Wondertan requested a review from renaynay as a code owner July 15, 2023 21:23
@Wondertan Wondertan self-assigned this Jul 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2023

Codecov Report

Merging #2482 (953b5b4) into main (d0e271e) will decrease coverage by 0.70%.
Report is 41 commits behind head on main.
The diff coverage is 45.71%.

@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   52.62%   51.92%   -0.70%     
==========================================
  Files         156      156              
  Lines       10007     9989      -18     
==========================================
- Hits         5266     5187      -79     
- Misses       4275     4346      +71     
+ Partials      466      456      -10     
Files Changed Coverage Δ
share/eds/store.go 57.28% <0.00%> (-3.95%) ⬇️
core/testing.go 87.23% <100.00%> (-4.63%) ⬇️
nodebuilder/init.go 47.46% <100.00%> (+0.67%) ⬆️

... and 7 files with indirect coverage changes

cmd/cel-shed/eds_store_stress.go Show resolved Hide resolved
cmd/cel-shed/eds_store_stress.go Show resolved Hide resolved
libs/edssser/edssser.go Outdated Show resolved Hide resolved
distractedm1nd
distractedm1nd previously approved these changes Aug 2, 2023
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, my only very optional nit would be naming (not so sure about EDSsser, don't see whats wrong with EDSStoreStresser)

@distractedm1nd
Copy link
Collaborator

let's of course merge vlad's improvement PR into this branch first

@Wondertan
Copy link
Member Author

@distractedm1nd, I just like saying EDSsssssser. It's first of a all a name, not abriviation

@Wondertan
Copy link
Member Author

Rebased on main

distractedm1nd
distractedm1nd previously approved these changes Aug 3, 2023
auto-merge was automatically disabled August 25, 2023 09:58

Rebase merges are not allowed on this repository

@Wondertan Wondertan merged commit 628559b into main Aug 25, 2023
15 of 17 checks passed
@Wondertan Wondertan deleted the hlib/eds/stresser branch August 25, 2023 12:21
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
walldiss pushed a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants