fix(share/eds)!: use separate badger for inverted index #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Wondertan
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Having same badger instance for dagstore shards and inverted index has proven to have hangup on Put operation for 1-10min.
According to @musalbas, no hangup happens with a single instance with 20 compactors. Is it worth verifying again to avoid having two badgers when we can have one only?
|
Considering inverted index is major bottleneck right now an we plan to remove it soon. I think it is worth to do separate badgers just for sake of easy migration. If we keep inverted index in same badger as shards badger, we would need to manually remove each key. It would mean to find all keys by prefix and remove them one by one, which will take ages. I've started test to try 20 compactors on single badger |
walldiss
changed the title
|
Agreed |
Wondertan
previously approved these changes
Jul 31, 2023
|
We still may wanna keep all the storage-breaking PRs together in a dedicated branch |
walldiss
changed the title
distractedm1nd
previously approved these changes
Aug 2, 2023
…ger_for_inverted_index # Conflicts: # go.mod
Wondertan
approved these changes
Aug 2, 2023
distractedm1nd
approved these changes
Aug 2, 2023
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 3, 2023
…2517) Having same badger instance for dagstore shards and inverted index has proven to have hangup on Put operation for 1-10min. During tests it has shown, that splitting badger into 2 instances solves the hangup issue. Also once celestiaorg#2479 is implemented and inverted index will needs to be removed. Separate badger will be much easier for users migration.
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
…2517) Having same badger instance for dagstore shards and inverted index has proven to have hangup on Put operation for 1-10min. During tests it has shown, that splitting badger into 2 instances solves the hangup issue. Also once celestiaorg#2479 is implemented and inverted index will needs to be removed. Separate badger will be much easier for users migration.
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
…2517) Having same badger instance for dagstore shards and inverted index has proven to have hangup on Put operation for 1-10min. During tests it has shown, that splitting badger into 2 instances solves the hangup issue. Also once celestiaorg#2479 is implemented and inverted index will needs to be removed. Separate badger will be much easier for users migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having same badger instance for dagstore shards and inverted index has proven to have hangup on
Putoperation for 1-10min. During tests it has shown, that splitting badger into 2 instances solves the hangup issue.Also once #2479 is implemented and inverted index will needs to be removed. Separate badger will be much easier for users migration.