fix(share/p2p): fix race in shrexeds test #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
area:shares
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2534 +/- ##
==========================================
+ Coverage 52.62% 52.65% +0.02%
==========================================
Files 156 156
Lines 10007 10026 +19
==========================================
+ Hits 5266 5279 +13
- Misses 4275 4285 +10
+ Partials 466 462 -4
|
Wondertan
approved these changes
Aug 2, 2023
distractedm1nd
approved these changes
Aug 3, 2023
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
Quick fix for race in test. Found in CI run
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
Quick fix for race in test. Found in CI run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Quick fix for race in test. Found in CI run