Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps + go1.21 #2589

Merged
merged 2 commits into from
Aug 22, 2023
Merged

chore: bump deps + go1.21 #2589

merged 2 commits into from
Aug 22, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Aug 21, 2023

Update to go1.21 was forced by go mod tidy. Theoretically, we could still live on go1.20 just supporting builds for people who run go1.21, but for some uninvestigated reason, we are forced to.

Closes #2566
Closes #2247

@codecov-commenter
Copy link

Codecov Report

Merging #2589 (eefaec9) into main (04e2928) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
- Coverage   51.20%   51.04%   -0.17%     
==========================================
  Files         157      157              
  Lines       10431    10431              
==========================================
- Hits         5341     5324      -17     
- Misses       4624     4641      +17     
  Partials      466      466              
Files Changed Coverage Δ
share/eds/byzantine/share_proof.go 45.71% <ø> (ø)
share/eds/eds.go 63.73% <ø> (ø)
share/getter.go 0.00% <ø> (ø)
share/p2p/shrexnd/server.go 48.12% <ø> (ø)

... and 5 files with indirect coverage changes

renaynay
renaynay previously approved these changes Aug 22, 2023
@Wondertan Wondertan merged commit 44a0b37 into main Aug 22, 2023
15 of 18 checks passed
@Wondertan Wondertan deleted the hlib/bump-libp2p branch August 22, 2023 10:23
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Aug 23, 2023
Update to go1.21 was forced by `go mod tidy`. Theoretically, we could
still live on go1.20 just supporting builds for people who run go1.21,
but for some uninvestigated reason, we are forced to.

Closes celestiaorg#2566
Closes celestiaorg#2247
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
Update to go1.21 was forced by `go mod tidy`. Theoretically, we could
still live on go1.20 just supporting builds for people who run go1.21,
but for some uninvestigated reason, we are forced to.

Closes celestiaorg#2566
Closes celestiaorg#2247

(cherry picked from commit 44a0b37)
walldiss pushed a commit that referenced this pull request Sep 22, 2023
Update to go1.21 was forced by `go mod tidy`. Theoretically, we could
still live on go1.20 just supporting builds for people who run go1.21,
but for some uninvestigated reason, we are forced to.

Closes #2566
Closes #2247

(cherry picked from commit 44a0b37)
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 25, 2023
Update to go1.21 was forced by `go mod tidy`. Theoretically, we could
still live on go1.20 just supporting builds for people who run go1.21,
but for some uninvestigated reason, we are forced to.

Closes celestiaorg#2566
Closes celestiaorg#2247

(cherry picked from commit 44a0b37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Go version 1.20, not higher drop minio dep for go >= 1.21
5 participants