Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/rpc): add commands for the p2p module #2599

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Aug 22, 2023

Overview

7wlmi5

Implemented rpc calls for the p2p module.

Adapted all cmds besides ResourceState as it contains a lot of information

FYI @jcstein

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:rpc kind:feat Attached to feature PRs labels Aug 22, 2023
@vgonkivs vgonkivs self-assigned this Aug 22, 2023
@vgonkivs vgonkivs force-pushed the rpc_partTwo_the_p2pModule_reborn branch from 2997e2b to bc87a7b Compare August 23, 2023 07:37
@vgonkivs vgonkivs marked this pull request as ready for review August 23, 2023 07:39
@jcstein
Copy link
Member

jcstein commented Aug 23, 2023

ack. can you please open an issue in docs when these are ready with details about what needs to be changed? / ping me so we can work on this together sync/async

Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we are doing these PRs to make sure help menus are populated?

cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
nodebuilder/p2p/p2p.go Outdated Show resolved Hide resolved
vgonkivs and others added 2 commits August 31, 2023 11:07
Co-authored-by: Ryan <ryan@celestia.org>
@vgonkivs vgonkivs changed the base branch from main to rpc_cmds_feature_branch August 31, 2023 08:54
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/p2p.go Outdated Show resolved Hide resolved
cmd/celestia/rpc.go Outdated Show resolved Hide resolved
nodebuilder/p2p/p2p.go Outdated Show resolved Hide resolved
vgonkivs and others added 4 commits August 31, 2023 15:58
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
cmd/celestia/rpc.go Outdated Show resolved Hide resolved
cmd/celestia/rpc.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the rpc_partTwo_the_p2pModule_reborn branch from ed3a3c7 to 50b344d Compare September 4, 2023 12:01
@codecov-commenter
Copy link

Codecov Report

Merging #2599 (8b99972) into rpc_cmds_feature_branch (9d663cf) will decrease coverage by 1.51%.
The diff coverage is 5.03%.

@@                     Coverage Diff                     @@
##           rpc_cmds_feature_branch    #2599      +/-   ##
===========================================================
- Coverage                    51.15%   49.64%   -1.51%     
===========================================================
  Files                          158      159       +1     
  Lines                        10559    10919     +360     
===========================================================
+ Hits                          5401     5421      +20     
- Misses                        4684     5024     +340     
  Partials                       474      474              
Files Changed Coverage Δ
cmd/celestia/blob.go 11.71% <0.00%> (+1.78%) ⬆️
cmd/celestia/p2p.go 5.21% <5.21%> (ø)
cmd/celestia/rpc.go 17.05% <5.26%> (-0.81%) ⬇️

... and 3 files with indirect coverage changes

@vgonkivs vgonkivs merged commit 34b62ec into celestiaorg:rpc_cmds_feature_branch Sep 4, 2023
13 of 15 checks passed
vgonkivs added a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rpc kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants