improvement!(blob/service): add options to submit

[vgonkivs]

Overview

Allows to configure fee and gasPrice in blob.Submit.
Closes #2629

Will update blob's rpc in a follow-up PR.

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

FYI @jcstein , @nashqueue

[codecov-commenter]

Codecov Report

Merging #2630 (c83e6f8) into main (196e849) will decrease coverage by 0.19%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2630      +/-   ##
==========================================
- Coverage   51.05%   50.87%   -0.19%     
==========================================
  Files         158      159       +1     
  Lines       10551    10614      +63     
==========================================
+ Hits         5387     5400      +13     
- Misses       4690     4736      +46     
- Partials      474      478       +4     

Files Changed	Coverage Δ
blob/batch.go	0.00% <0.00%> (ø)
blob/service.go	71.60% <0.00%> (-1.24%)	⬇️
cmd/celestia/blob.go	9.86% <0.00%> (-0.07%)	⬇️

... and 12 files with indirect coverage changes

[vgonkivs]

After a discussion with @distractedm1nd, we figured out that the Option param won't work on the RPC because 'Option' is a typedef on a func() and marshalling functions/methods does not make much sense, so the request will fail. We agreed to have one more endpoint SubmitWithFee that will have fee+gaslimit as input params, and Submit will be used as blobs submitter with the default fee and gasLim

[vgonkivs]

One more idea came to my mind: we can rework blob.Submit by getting new type blob.Batch.

type Batch struct {
   Blob []*Blob
   Fee int64
  GasLimit uint64
}

func NewBatch(blobs *[]Blob) *Batch {
  return &Batch {
     Blob: blobs,
     Fee: -1,
}

type func(*Batch) Option

func WithFee(int64) Option {}
func WithGasLimit(uint64) Option {}
}

func(s *service)Submit(ctx context.Contex, blobs *Batch){}

[vgonkivs]

Anyway we are going to make breaking changes but the second approach looks better to me as we will still have a single endpoint for the Submit

[renaynay]

@vgonkivs please don't break the method yet - let's just extend it by adding the additional SubmitWithOptions and have a struct called SubmissionOptions or just Options that contains fee and gas limit as field

i think the concept of batch is unnecessarily confusing

[vgonkivs]

ok

[ramin]

i like this and changes are good. I'll defer to @renaynay and @Wondertan on if they approve/deny the breaking change to Submit RPC but the things i suggested ==

[renaynay]

Fine w me

[Wondertan]

Please make an issue to fix variadics and gtg