Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(share)!: have NamespacedShares fields use snake_case in JSON #2633

Merged
merged 5 commits into from
Sep 4, 2023
Merged

refactor(share)!: have NamespacedShares fields use snake_case in JSON #2633

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02931a3
refactor(share)!: have NamespacedShares fields use snake_case in JSON
distractedm1nd Aug 29, 2023
ef9e0bb
Merge branch 'main' into namespacedshares_snake
distractedm1nd Sep 4, 2023
e739143
Merge branch 'main' into namespacedshares_snake
distractedm1nd Sep 4, 2023
12f7376
fix: linter
distractedm1nd Sep 4, 2023
40eed66
Merge branch 'main' into namespacedshares_snake
distractedm1nd Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions share/getter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ import (
var (
// ErrNotFound is used to indicate that requested data could not be found.
ErrNotFound = errors.New("share: data not found")
// ErrOutOfBounds is used to indicate that a passed row or column index is out of bounds of the square size.
// ErrOutOfBounds is used to indicate that a passed row or column index is out of bounds of the
// square size.
ErrOutOfBounds = errors.New("share: row or column index is larger than square size")
)

Expand Down Expand Up @@ -50,8 +51,8 @@ func (ns NamespacedShares) Flatten() []Share {

// NamespacedRow represents all shares with proofs within a specific namespace of a single EDS row.
type NamespacedRow struct {
Shares []Share
Proof *nmt.Proof
Shares []Share `json:"shares"`
Proof *nmt.Proof `json:"proof"`
}

// Verify validates NamespacedShares by checking every row with nmt inclusion proof.
Expand Down
Loading