Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modp2p): listen on WebTransport by default #2660

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

Wondertan
Copy link
Member

We already support WT as part of default libp2p supported transport, but node won't receive any connections unless they explicitly listen to them and this PR changes that/

@Wondertan Wondertan added the kind:feat Attached to feature PRs label Sep 5, 2023
@Wondertan Wondertan self-assigned this Sep 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2660 (1a5e39d) into main (c146a0a) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2660      +/-   ##
==========================================
+ Coverage   51.00%   51.11%   +0.10%     
==========================================
  Files         158      158              
  Lines       10657    10662       +5     
==========================================
+ Hits         5436     5450      +14     
+ Misses       4744     4734      -10     
- Partials      477      478       +1     
Files Changed Coverage Δ
nodebuilder/p2p/config.go 78.04% <100.00%> (+3.04%) ⬆️

... and 6 files with indirect coverage changes

@Wondertan Wondertan merged commit a5e01b9 into main Sep 6, 2023
17 of 19 checks passed
@Wondertan Wondertan deleted the hlib/listen-on-webt branch September 6, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants