Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale issue github workflow #2667

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Stale issue github workflow #2667

merged 4 commits into from
Sep 13, 2023

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Sep 7, 2023

Overview

Adds a basic stale issue and PR workflow. Will run one a day. I've only moderately changed the defaults so it is less aggressive on closing old issues. I also added recognition of a keep-open label that we can add add to an issue to....keep it open if we really love one of these old issues and consider it part of the team now

PRs will

  • get a stale tag after 60 days
  • be autoclosed 14 days after no additional activity

Issues

  • get a stale tag after 90 days
  • be autoclosed 21 days after no additional activity
  • can be kept alive with keep-open

Checklist

  • [n/a] New and updated code has appropriate documentation
  • [n/a ] New and updated code has new and/or updated testing
  • Required CI checks are passing
  • [n/a] Visual proof for any user facing features like CLI or documentation updates
  • [n/a] Linked issues closed with keywords

@Wondertan
Copy link
Member

How does it work for existing issues and PRs? Will it count the inactivity from when the workflow starts, or will it immediately mark all the old issues and PRs as stale?

@ramin
Copy link
Contributor Author

ramin commented Sep 7, 2023

How does it work for existing issues and PRs? Will it count the inactivity from when the workflow starts, or will it immediately mark all the old issues and PRs as stale?

@Wondertan it'll just start looking at everything. There IS a config to set a start-date param we can set which will only look at PRs and Issues created after the date. Shall we set that from today and it'll just sweep going forward?

https://github.com/actions/stale#start-date

@Wondertan
Copy link
Member

Wondertan commented Sep 8, 2023

Shall we set that from today and it'll just sweep going forward?

SGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #2667 (e21eeae) into main (bf31c4f) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2667      +/-   ##
==========================================
+ Coverage   51.16%   51.33%   +0.16%     
==========================================
  Files         159      159              
  Lines       10697    10697              
==========================================
+ Hits         5473     5491      +18     
+ Misses       4742     4729      -13     
+ Partials      482      477       -5     

see 5 files with indirect coverage changes

@Wondertan Wondertan merged commit 28bd438 into main Sep 13, 2023
16 of 18 checks passed
@Wondertan Wondertan deleted the feat/ramin/stale-issues branch September 13, 2023 09:23
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants