Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): add state cmd #2691

Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat(rpc): add state cmd #2691

merged 4 commits into from
Sep 15, 2023

Conversation

vgonkivs
Copy link
Member

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:rpc kind:feat Attached to feature PRs labels Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (rpc_cmds_feature_branch@0794b5d). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             rpc_cmds_feature_branch    #2691   +/-   ##
==========================================================
  Coverage                           ?   48.08%           
==========================================================
  Files                              ?      164           
  Lines                              ?    11534           
  Branches                           ?        0           
==========================================================
  Hits                               ?     5546           
  Misses                             ?     5510           
  Partials                           ?      478

@vgonkivs vgonkivs self-assigned this Sep 14, 2023
@vgonkivs vgonkivs marked this pull request as ready for review September 14, 2023 10:51
renaynay
renaynay reviewed Sep 14, 2023
View reviewed changes
cmd/celestia/state.go Outdated Show resolved Hide resolved
cmd/celestia/state.go Outdated Show resolved Hide resolved
@vgonkivs
Copy link
Member Author

For some reason, lint is not working on CI(Works for me locally)

Wondertan
Wondertan reviewed Sep 14, 2023
View reviewed changes
cmd/celestia/state.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs merged commit 14ea252 into celestiaorg:rpc_cmds_feature_branch Sep 15, 2023
10 of 13 checks passed
vgonkivs added a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
@vgonkivs
feat(rpc): add state cmd (celestiaorg#2691)
cc02d71
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan left review comments

@renaynay renaynay renaynay left review comments

@ramin ramin ramin approved these changes

@walldiss walldiss walldiss approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

Assignees

@vgonkivs vgonkivs

Labels
area:rpc kind:feat Attached to feature PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vgonkivs @codecov-commenter @ramin @walldiss @Wondertan @renaynay