Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(swamp): use RPC client instead of service pointers #2699

Merged
merged 3 commits into from
Sep 13, 2023
Merged

refactor(swamp): use RPC client instead of service pointers #2699

merged 3 commits into from
Sep 13, 2023

Conversation

distractedm1nd
Copy link
Collaborator

Replaces #2356
First step of #2337

@distractedm1nd distractedm1nd added kind:testing Related to unit tests swamp Related to Integration tests labels Sep 12, 2023
@distractedm1nd distractedm1nd self-assigned this Sep 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #2699 (a257011) into main (28bd438) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2699      +/-   ##
==========================================
- Coverage   51.30%   51.28%   -0.02%     
==========================================
  Files         159      159              
  Lines       10697    10697              
==========================================
- Hits         5488     5486       -2     
  Misses       4731     4731              
- Partials      478      480       +2
Files Changed Coverage Δ
nodebuilder/node.go 58.57% <ø> (ø)

... and 6 files with indirect coverage changes

Wondertan
Wondertan approved these changes Sep 12, 2023
View reviewed changes
nodebuilder/tests/api_test.go Show resolved Hide resolved
@distractedm1nd distractedm1nd enabled auto-merge (squash) September 13, 2023 09:12
@distractedm1nd distractedm1nd merged commit 9260a8b into main Sep 13, 2023
15 of 17 checks passed
@distractedm1nd distractedm1nd deleted the swamp-rpc branch September 13, 2023 09:43
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
@distractedm1nd @vgonkivs
refactor(swamp): use RPC client instead of service pointers (celestia…
84b5988 
…org#2699)

Replaces celestiaorg#2356 
First step of celestiaorg#2337
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgonkivs vgonkivs vgonkivs approved these changes

@Wondertan Wondertan Wondertan approved these changes

@ramin ramin ramin approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@distractedm1nd distractedm1nd

Labels
kind:testing Related to unit tests swamp Related to Integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@distractedm1nd @codecov-commenter @ramin @Wondertan @vgonkivs