Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): add admin cmd #2701

Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat(rpc): add admin cmd #2701

merged 4 commits into from
Sep 15, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Sep 14, 2023 •
edited
Loading

Overview

Added node cmds
celestia node info
celestia node log-level *:debug
celestia node permissions <token>
celestia node set-permissions <perm1> <perm2> ...

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:rpc kind:feat Attached to feature PRs labels Sep 14, 2023
@vgonkivs vgonkivs self-assigned this Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (rpc_cmds_feature_branch@0794b5d). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             rpc_cmds_feature_branch    #2701   +/-   ##
==========================================================
  Coverage                           ?   49.09%           
==========================================================
  Files                              ?      163           
  Lines                              ?    11270           
  Branches                           ?        0           
==========================================================
  Hits                               ?     5533           
  Misses                             ?     5260           
  Partials                           ?      477

Wondertan
Wondertan reviewed Sep 14, 2023
View reviewed changes
cmd/celestia/admin.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Sep 14, 2023
View reviewed changes
cmd/celestia/admin.go Outdated Show resolved Hide resolved
Wondertan
Wondertan approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!

Wondertan
Wondertan reviewed Sep 14, 2023
View reviewed changes
cmd/celestia/admin.go Outdated Show resolved Hide resolved
@vgonkivs @Wondertan
apply suggestion
c400d0b 
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
@vgonkivs vgonkivs merged commit b261a0c into celestiaorg:rpc_cmds_feature_branch Sep 15, 2023
12 of 15 checks passed
vgonkivs added a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
@vgonkivs
feat(rpc): add admin cmd (celestiaorg#2701)
c38fcb7
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@vgonkivs vgonkivs

Labels
area:rpc kind:feat Attached to feature PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgonkivs @codecov-commenter @Wondertan