Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps!: Bumps go-header #2844

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Oct 13, 2023

Bumps go-header - includes breaks to Getter interface + metrics instantiation for header pkg

@renaynay renaynay changed the title Bump header break deps!: Bumps go-header Oct 13, 2023
@renaynay renaynay added kind:deps Pull requests that update a dependency file kind:break! Attached to breaking PRs labels Oct 13, 2023
@renaynay renaynay self-assigned this Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #2844 (1bda27f) into main (00b32a8) will decrease coverage by 0.10%.
Report is 7 commits behind head on main.
The diff coverage is 46.93%.

@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   51.50%   51.41%   -0.10%     
==========================================
  Files         168      167       -1     
  Lines       10764    10756       -8     
==========================================
- Hits         5544     5530      -14     
+ Misses       4743     4730      -13     
- Partials      477      496      +19     
Files Coverage Δ
nodebuilder/header/config.go 53.96% <ø> (ø)
nodebuilder/settings.go 51.14% <100.00%> (+1.53%) ⬆️
nodebuilder/header/header.go 0.00% <0.00%> (ø)
nodebuilder/header/service.go 7.69% <0.00%> (ø)
nodebuilder/header/module.go 47.61% <50.00%> (-5.02%) ⬇️
core/exchange.go 53.27% <53.33%> (+17.42%) ⬆️
nodebuilder/header/constructors.go 41.42% <31.25%> (-8.58%) ⬇️

... and 16 files with indirect coverage changes

@renaynay renaynay marked this pull request as ready for review October 13, 2023 13:41
vgonkivs
vgonkivs previously approved these changes Oct 13, 2023
@Wondertan Wondertan enabled auto-merge (squash) October 13, 2023 15:17
@Wondertan Wondertan merged commit 422dea2 into celestiaorg:main Oct 13, 2023
15 of 17 checks passed
@renaynay renaynay deleted the bump-header-break branch October 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:break! Attached to breaking PRs kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants