Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix duplicate docker build stages #2845

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 13, 2023

Overview

Final bug fix celestiaorg/.github#82

Visual proof of action executing as expected now
https://github.com/celestiaorg/celestia-node/actions/runs/6509222904/job/17680437495
Screen Shot 2023-10-13 at 10 13 28 AM

@github-actions github-actions bot added the external Issues created by non node team members label Oct 13, 2023
@MSevey MSevey added bug Something isn't working kind:fix Attached to bug-fixing PRs github_actions Pull requests that update GitHub Actions code labels Oct 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2845 (c52cd65) into main (a52e2de) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2845      +/-   ##
==========================================
- Coverage   51.30%   51.24%   -0.06%     
==========================================
  Files         168      168              
  Lines       10744    10744              
==========================================
- Hits         5512     5506       -6     
- Misses       4750     4757       +7     
+ Partials      482      481       -1     

see 8 files with indirect coverage changes

@MSevey MSevey marked this pull request as ready for review October 13, 2023 14:14
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@Wondertan Wondertan merged commit 34775bb into main Oct 13, 2023
15 of 17 checks passed
@Wondertan Wondertan deleted the sevey/dumb-docker-action branch October 13, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues created by non node team members github_actions Pull requests that update GitHub Actions code kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants