-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(p2p): Start listening to QUIC when CELESTIA_ENABLE_QUIC is set #2857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and good catch!
Did you test if it fixes your issue? @oblique |
Yes I was able to run a node that had QUIC and WebTransport enabled. |
Codecov Report
@@ Coverage Diff @@
## main #2857 +/- ##
==========================================
+ Coverage 51.16% 51.38% +0.22%
==========================================
Files 167 167
Lines 10773 10775 +2
==========================================
+ Hits 5512 5537 +25
+ Misses 4764 4738 -26
- Partials 497 500 +3
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Overview
The
enableQUIC
was not applied in theListen
.Related: #2837
Checklist