Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(p2p): Start listening to QUIC when CELESTIA_ENABLE_QUIC is set #2857

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Oct 18, 2023

Overview

The enableQUIC was not applied in the Listen.

Related: #2837

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions github-actions bot added the external Issues created by non node team members label Oct 18, 2023
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and good catch!

@Wondertan
Copy link
Member

Did you test if it fixes your issue? @oblique

@oblique
Copy link
Contributor Author

oblique commented Oct 18, 2023

Yes I was able to run a node that had QUIC and WebTransport enabled.

@renaynay renaynay enabled auto-merge (squash) October 18, 2023 14:40
@codecov-commenter
Copy link

Codecov Report

Merging #2857 (45a3427) into main (0b85448) will increase coverage by 0.22%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2857      +/-   ##
==========================================
+ Coverage   51.16%   51.38%   +0.22%     
==========================================
  Files         167      167              
  Lines       10773    10775       +2     
==========================================
+ Hits         5512     5537      +25     
+ Misses       4764     4738      -26     
- Partials      497      500       +3     
Files Coverage Δ
blob/service.go 70.12% <100.00%> (ø)
nodebuilder/p2p/addrs.go 75.00% <100.00%> (+1.19%) ⬆️

... and 7 files with indirect coverage changes

@Wondertan Wondertan added the kind:fix Attached to bug-fixing PRs label Oct 18, 2023
@renaynay renaynay merged commit 40eea90 into celestiaorg:main Oct 18, 2023
16 of 20 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 18, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

GitPOAP: 2023 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:p2p external Issues created by non node team members kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants