-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Enable metrics for core package #2863
Conversation
a43ec7f
to
b5460a8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2863 +/- ##
==========================================
- Coverage 51.67% 51.38% -0.29%
==========================================
Files 167 170 +3
Lines 10812 10925 +113
==========================================
+ Hits 5587 5614 +27
- Misses 4729 4810 +81
- Partials 496 501 +5 ☔ View full report in Codecov by Sentry. |
b5460a8
to
5df3059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that we don't need blockTime metric. The bridge node publishes headers through Subscriber, which goes through that validator, and time is tracked there on subscriber metrics. So effectively we will get the same time twice
5df3059
to
403bc9a
Compare
@Wondertan the reason i wanted to capture block time here is that it's the only way to know on the DA-side what the approximate block time is so that we can see if there's a difference between core network block time and DA header propagation time. I removed it in this commit 403bc9a |
I understand and it turns out we designed things in a way that we don't need to duplicate anything 😺 |
We should aim to include fetcher metrics here as well |
Linter btw |
beb64d4
to
05b6665
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While we do plan to remove the
bridge
node type eventually, it's useful to have some visibility into the core package in the short term.