-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(share/byzantine): extend befp tests #2864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
October 19, 2023 15:06
Codecov Report
@@ Coverage Diff @@
## main #2864 +/- ##
==========================================
+ Coverage 51.62% 51.76% +0.13%
==========================================
Files 167 167
Lines 10777 10787 +10
==========================================
+ Hits 5564 5584 +20
+ Misses 4720 4709 -11
- Partials 493 494 +1
|
renaynay
previously approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit (that applies to the table tests that expect an err)
distractedm1nd
previously approved these changes
Oct 23, 2023
Wondertan
requested changes
Oct 23, 2023
vgonkivs
dismissed stale reviews from distractedm1nd and renaynay
via
October 23, 2023 19:34
b8d1bc0
vgonkivs
force-pushed
the
extend_befp_unit_tests
branch
from
October 23, 2023 19:34
9954362
to
b8d1bc0
Compare
vgonkivs
force-pushed
the
extend_befp_unit_tests
branch
2 times, most recently
from
October 24, 2023 10:02
923ade4
to
b8c50bf
Compare
Wondertan
previously approved these changes
Oct 24, 2023
Linter dou |
walldiss
previously approved these changes
Oct 24, 2023
Wondertan
previously approved these changes
Oct 24, 2023
vgonkivs
force-pushed
the
extend_befp_unit_tests
branch
from
October 25, 2023 08:56
c815687
to
7face31
Compare
walldiss
previously approved these changes
Oct 25, 2023
renaynay
previously approved these changes
Oct 25, 2023
Wondertan
approved these changes
Oct 25, 2023
renaynay
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extend test cases for befp.Validate.
Checklist