Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(share/byzantine): extend befp tests #2864

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

vgonkivs
Copy link
Member

Overview

Extend test cases for befp.Validate.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #2864 (c434508) into main (43e6bbf) will increase coverage by 0.13%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
+ Coverage   51.62%   51.76%   +0.13%     
==========================================
  Files         167      167              
  Lines       10777    10787      +10     
==========================================
+ Hits         5564     5584      +20     
+ Misses       4720     4709      -11     
- Partials      493      494       +1     
Files Coverage Δ
share/eds/byzantine/bad_encoding.go 50.00% <69.56%> (+18.11%) ⬆️

... and 5 files with indirect coverage changes

renaynay
renaynay previously approved these changes Oct 20, 2023
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit (that applies to the table tests that expect an err)

share/eds/byzantine/bad_encoding_test.go Outdated Show resolved Hide resolved
distractedm1nd
distractedm1nd previously approved these changes Oct 23, 2023
share/eds/byzantine/bad_encoding_test.go Show resolved Hide resolved
share/eds/byzantine/bad_encoding_test.go Outdated Show resolved Hide resolved
share/eds/byzantine/bad_encoding_test.go Outdated Show resolved Hide resolved
Wondertan
Wondertan previously approved these changes Oct 24, 2023
@Wondertan
Copy link
Member

Linter dou

walldiss
walldiss previously approved these changes Oct 24, 2023
@vgonkivs vgonkivs dismissed stale reviews from walldiss and Wondertan via c815687 October 24, 2023 16:22
Wondertan
Wondertan previously approved these changes Oct 24, 2023
walldiss
walldiss previously approved these changes Oct 25, 2023
renaynay
renaynay previously approved these changes Oct 25, 2023
share/eds/byzantine/bad_encoding.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs dismissed stale reviews from renaynay, walldiss, and Wondertan via c434508 October 25, 2023 10:22
@vgonkivs vgonkivs merged commit 565691f into celestiaorg:main Oct 25, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:chore kind:testing Related to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants