Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blob/service): handle absence proof #2911

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Nov 7, 2023

Fixes #2860

Proof:

Снимок экрана 2023-11-07 в 16 49 57

@vgonkivs vgonkivs added kind:fix Attached to bug-fixing PRs area:blob labels Nov 7, 2023
@vgonkivs vgonkivs requested a review from ramin November 7, 2023 14:54
@vgonkivs vgonkivs self-assigned this Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #2911 (ce3de80) into main (1ae18c9) will decrease coverage by 0.45%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
- Coverage   51.78%   51.34%   -0.45%     
==========================================
  Files         167      167              
  Lines       10806    10812       +6     
==========================================
- Hits         5596     5551      -45     
- Misses       4717     4767      +50     
- Partials      493      494       +1     
Files Coverage Δ
share/getters/shrex.go 65.55% <100.00%> (ø)
share/eds/utils.go 14.45% <0.00%> (ø)
blob/service.go 67.64% <0.00%> (-4.31%) ⬇️

... and 8 files with indirect coverage changes

share/getter.go Outdated Show resolved Hide resolved
@Wondertan Wondertan enabled auto-merge (squash) November 9, 2023 13:10
@vgonkivs vgonkivs force-pushed the handle_absence_proof branch 2 times, most recently from 066ac71 to 3af918d Compare November 10, 2023 10:12
@Wondertan Wondertan merged commit 1823aee into celestiaorg:main Nov 10, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob: TestBlobService_Get is flaky
4 participants