fix(test/daser): stop the eds store before finishing the test #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
kind:testing
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
Wondertan
approved these changes
Nov 8, 2023
ramin
approved these changes
Nov 9, 2023
vgonkivs
force-pushed
the
fix_flakiness_in_daser_tests
branch
from
fd2309d
to
84b9ae7
Compare
Codecov Report
@@ Coverage Diff @@
## main #2918 +/- ##
==========================================
+ Coverage 50.26% 51.75% +1.49%
==========================================
Files 167 167
Lines 10801 10806 +5
==========================================
+ Hits 5429 5593 +164
+ Misses 4888 4720 -168
- Partials 484 493 +9
|
renaynay
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests that used TestAvailability were flaky. They could randomly receive
tempdir remove all cleanup unlinkat directory not empty. It happened to me 100% time when I was running a test with--count > 50. It happened because the eds store was storing the data and the temp folder could not be deleted.