Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodebuilder/prune)!: Enable sampling window for light nodes #2991

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Dec 5, 2023

This PR enforces a sampling window of 30 days' worth of seconds for light nodes. The DASer will now skip over sampling headers that fall outside this range.

I've labeled this PR as breaking as it contains a behavioural break (sampling constrained to a 30-day window rather than all historical headers).

@renaynay renaynay added kind:feat Attached to feature PRs kind:break! Attached to breaking PRs area:das Related to DASer labels Dec 5, 2023
@renaynay renaynay self-assigned this Dec 5, 2023
Copy link
Contributor

@ramin ramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b7b6350) 50.88% compared to head (be5008e) 51.06%.
Report is 1 commits behind head on main.

Files Patch % Lines
das/daser.go 61.53% 4 Missing and 1 partial ⚠️
nodebuilder/das/constructors.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
+ Coverage   50.88%   51.06%   +0.18%     
==========================================
  Files         168      168              
  Lines       11021    11040      +19     
==========================================
+ Hits         5608     5638      +30     
+ Misses       4915     4898      -17     
- Partials      498      504       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@renaynay renaynay enabled auto-merge (squash) January 4, 2024 15:15
@renaynay renaynay merged commit 45e1847 into celestiaorg:main Jan 4, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:das Related to DASer kind:break! Attached to breaking PRs kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants