Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodebuilder/p2p)!: add arabica-11 #3066

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

smuu
Copy link
Member

@smuu smuu commented Jan 2, 2024

No description provided.

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@github-actions github-actions bot added the external Issues created by non node team members label Jan 2, 2024
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks<3

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b487830) 51.00% compared to head (0330925) 51.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3066      +/-   ##
==========================================
+ Coverage   51.00%   51.21%   +0.21%     
==========================================
  Files         177      177              
  Lines       11147    11147              
==========================================
+ Hits         5685     5709      +24     
+ Misses       4959     4939      -20     
+ Partials      503      499       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramin ramin added the kind:misc Attached to miscellaneous PRs label Jan 2, 2024
@renaynay renaynay changed the title feat: add arabica-11 chore(nodebuilder/p2p)!: add arabica-11 Jan 2, 2024
@renaynay
Copy link
Member

renaynay commented Jan 2, 2024

Marking as breaking since it's a networkID change

@renaynay renaynay merged commit d517e3c into celestiaorg:main Jan 3, 2024
17 of 19 checks passed
@smuu smuu deleted the smuu/add-arabica-11-cluster branch January 4, 2024 09:18
renaynay added a commit to renaynay/celestia-node that referenced this pull request Jan 15, 2024
<!--
Thank you for submitting a pull request!

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

Please ensure you've addressed or included references to any related
issues.

Tips:
- Use keywords like "closes" or "fixes" followed by an issue number to
automatically close related issues when the PR is merged (e.g., "closes
#123" or "fixes #123").
- Describe the changes made in the PR.
- Ensure the PR has one of the required tags (kind:fix, kind:misc,
kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci,
kind:chore, kind:testing)

-->

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants